Skip to content

Http2 X-forwarded headers #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dajinchu merged 1 commit into from
Feb 16, 2026
Merged

Http2 X-forwarded headers #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions bifrost-fastify/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
import { FastifyRequest, RequestGenericInterface } from "fastify/types/request";
import proxy, { type FastifyHttpProxyOptions } from "@fastify/http-proxy";
import accepts from "@fastify/accepts";
import forwarded from "@fastify/forwarded";
import type { GetLayout, WrappedServerOnly } from "@alignable/bifrost/config";
import { renderPage } from "vike/server";
import { PageContextServer } from "vike/types";
Expand Down Expand Up @@ -192,12 +191,18 @@ export const viteProxyPlugin: FastifyPluginAsync<
},
replyOptions: {
rewriteRequestHeaders(request, headers) {
if (!(request.raw instanceof Http2ServerRequest)) {
const fwd = forwarded(request.raw).reverse();
headers["X-Forwarded-For"] = fwd.join(", ");
headers["X-Forwarded-Host"] = host.host;
Copy link
Collaborator Author

@dajinchu dajinchu Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setting x-forwarded-host/protocol is required for rails to work properly

headers["X-Forwarded-Proto"] = host.protocol;
// Build X-Forwarded-For from existing header + socket address
const existingFor = request.headers["x-forwarded-for"];
const clientIp = request.raw.socket?.remoteAddress;
if (existingFor && clientIp) {
headers["X-Forwarded-For"] = `${clientIp}, ${existingFor}`;
} else if (existingFor) {
headers["X-Forwarded-For"] = existingFor;
} else if (clientIp) {
headers["X-Forwarded-For"] = clientIp;
}
headers["X-Forwarded-Host"] = host.host;
headers["X-Forwarded-Proto"] = host.protocol.replace(":", "");

if ((request.raw as RawRequestExtendedWithProxy)._bfproxy) {
// Proxying and wrapping
Expand Down
1 change: 0 additions & 1 deletion bifrost-fastify/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"types": "./dist/index.d.ts",
"dependencies": {
"@fastify/accepts": "^5.0.4",
"@fastify/forwarded": "^3.0.1",
"@fastify/http-proxy": "^11.4.1",
"@fastify/reply-from": "^12.5.0",
"fast-content-type-parse": "^3.0.0",
Expand Down
1 change: 0 additions & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.