Fix IOS opening in safari on wrapped proxy errors#73
Merged
Conversation
dajinchu
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IOS app opening the page in Safari when switching from wrapped proxy -> rails.
The bug:
throw redirect(resp.url)which contains the entire URL with base domain/so decides to callwindow.location.href=resp.urlwindow.location.href = {absolute URL}calls and passes this info to AlignableAppThe fix:
Convert window.location.href={absolute url} to window.location.href={relative url} when redirecting to the same domain.
Why no tests?
I couldn't find a way to mock the window.location.href setter with playwright. Most things I have tried results in
Uncaught TypeError: Cannot redefine property: location.