feat(calendar): add SOGoCalendarAlarmsDisabled preference and skip past alarm popups#392
Open
tobias-weiss-ai-xr wants to merge 1 commit into
Open
Conversation
…st alarm popups Two improvements for calendar alarm popups: 1. SOGoCalendarAlarmsDisabled: New user default preference to disable calendar alarm popups entirely. Set to YES to suppress all alarm toasts. 2. Past alarm filtering: Alarms whose trigger time is already in the past are now silently dismissed on the server without showing a popup. This prevents the cascading backlog of overdue popups when a user returns after a prolonged absence. Closes: Calendar alarm popup UX issue where overdue alarms would queue up and bombard the user with non-dismissable toasts. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Calendar alarm popups (md-toasts) with
hideDelay: 0persist indefinitely. When a user returns after hours away, all overdue alarms are queued and fire one after another — each blocking the UI until dismissed. On small screens, the toast overlaps the event entry dialog's save button, making it impossible to save appointments for minutes at a time.Changes
1. Past alarm filtering (
getAlarms)Alarms whose trigger time is already in the past are now silently dismissed on the server (
?resetAlarm=yes) without showing a popup. Only future alarms show a toast. This prevents the cascading backlog of overdue popups.2.
SOGoCalendarAlarmsDisabledpreferenceNew user default to disable calendar alarm popups entirely. Set
SOGoCalendarAlarmsDisabled = YESin user defaults to suppress all alarm polling and toast display.Affected file
UI/WebServerResources/js/Preferences/Preferences.service.js