-
-
Notifications
You must be signed in to change notification settings - Fork 25
Add --dry-run flag to CLI and dry_run option to API #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Einswilli kindly see my work and if its is okay kindly merge and give me feedback |
Einswilli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
It'be great to display also file paths in verbose mode.
Thanks for your contributions!
|
Hi @Einswilli I have removed the unnecessary blocks you mentioned above and added the matched_files. block in the download.py
|
Einswilli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks cleaner 👍🏾
Great work!






Summary
This PR adds a "dry-run" preview mode to Forklet so users can see which files would be downloaded without creating directories or writing files.
--dry-run/-noption toforklet download.dry_run: boolsupport toDownloadRequest.dry_runis True and returns aDownloadResult-like summary.tests/core/test_orchestrator_dry_run.py.Why this change
What Changed
Files changed (high-level)
dry_run: bool = FalsetoDownloadRequest.--dry-run / -nclick option todownloadcommand.python -m forklet.dry_runintoDownloadRequest._current_resultearlier for consistent status endpoints.dry_run=Truereturns the expected summary and does not create files.Behavior
--dry-runis passed, Forklet:downloaded_files == []and does NOT create directories or write files.--verboseincreases logging and shows debug lines.How to test (quick)
masteras ref for TheAlgorithms/Python):Notes for reviewers
DownloadResult-like object (status set to COMPLETED). If reviewers prefer an explicitwas_dry_runflag on the result, I can add that in a follow-up.Checklist for merge
closes #60