Open
Conversation
askewc
requested changes
Jun 11, 2020
Collaborator
askewc
left a comment
askewc
left a comment
There was a problem hiding this comment.
Looks pretty good, man!! Only one nit.
| <p>Please put in the address of your favorite coffee place: </p> | ||
| <input type="text" name="address"> | ||
| </br> | ||
| <p> Is your coffee place a starbucks?</p> |
Owner
Author
There was a problem hiding this comment.
addressed in latest commit!
zkoogle
reviewed
Jun 12, 2020
| /* Represents a user-uploaded coffee shop at specific address */ | ||
| public class Cafe { | ||
| String address; | ||
| boolean isStarbucks; |
Collaborator
There was a problem hiding this comment.
Can you make this class "Immutable"? An example I found from the web:
https://howtodoinjava.com/java/basics/how-to-make-a-java-class-immutable/
zkoogle
reviewed
Jun 12, 2020
| this.isStarbucks = starbucks; | ||
| } | ||
|
|
||
| public static Cafe makeNewCafe(String address, boolean starbucks) { |
Collaborator
There was a problem hiding this comment.
This doesn't really have much benefit in this case. We make a separate static creator when there is a complex business logic to call the constructor. There is no reason to hide the constructor if the parameters are identical.
| private final boolean isStarbucks; | ||
|
|
||
| public Cafe(String address, boolean starbucks) { | ||
| private Cafe(String address, boolean starbucks) { |
Collaborator
There was a problem hiding this comment.
I'd prefer the 'isStarbucks' to 'starbucks'.
Collaborator
|
LGTM. Please resolve the conflict. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users able to upload addresses of their favorite coffee shops to the datastore server with light maps integration on the maps.html page.
Note: if there's blobstore stuff in here, that's because this branch was intended to build off blobstore integration but then blobstore was removed from the project - disregard any mentions and sorry about that!
EDIT: deployed to this link