Feat/9 submodule size support#247
Open
envico801 wants to merge 2 commits into
Open
Conversation
Detects submodules via external repository links, calculates their working-tree size for consistency, and lazy-loads the results into the UI using a Promise cache to prevent blocking the main thread and duplicate API requests.
Author
|
Worth mentioning that submodules are not considered in the total size sum of the parent repository, as they are references basically |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for displaying Git submodule sizes directly in the parent repository view.
Previously, submodules would always display
...because their paths point to a different repository and fail the normal tree lookup logic.What changed
owner/repodiffers from the current repository.Submodules now initially render as
Loading...and update automatically once the request completes.This can be reproduced with:
Files changed
getExternalRepoSize()inapi.tsdom-manipulation.tsCloses #9
Before:
After: