Fix support absolute GitHub URLs in path parser#249
Open
envico801 wants to merge 1 commit into
Open
Conversation
Handle cases where GitHub renders absolute URLs instead of relative paths in repository file links, which can occur on forks and certain SPA navigation flows. Normalize links to pathname-only URLs before performing index-based path extraction to ensure consistent repository path parsing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Handle absolute GitHub URLs in file links
This PR fixes an issue where file sizes could incorrectly display as
"..."when browsing certain forks or navigating through GitHub's SPA interface.Root cause
The extension currently assumes GitHub file links are always relative URLs:
However, GitHub sometimes injects absolute URLs into the DOM instead:
get-path-object.tsparses paths using index-based splitting:This works for relative paths:
but fails for absolute URLs:
Because the indices shift, the parser extracts invalid paths such as:
instead of:
This causes repository tree lookups to fail, resulting in
"..."placeholders.This can be reproduced with:
Solution
Normalize all incoming URLs before parsing.
If the path is absolute:
URL.pathnameThis guarantees consistent parsing regardless of how GitHub renders the link.
This PR assumes that #246 is already merged or will be, so part of that PR is present on this one, due to both touching the same file.
Before:
After: