Merged
Conversation
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
6 times, most recently
from
71d735b to
ffc131f
Compare
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
2 times, most recently
from
25ab29e to
41e353c
Compare
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
from
41e353c to
b41c2a0
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
from
b54002e to
247951b
Compare
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
from
247951b to
b8db259
Compare
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
2 times, most recently
from
fea90e7 to
01aa074
Compare
JonaBenja
force-pushed
the
jona/entra_authorize_button
branch
from
01aa074 to
5fd8597
Compare
jasper-jager
previously approved these changes
Mar 11, 2026
Contributor
jasper-jager
left a comment
jasper-jager
left a comment
There was a problem hiding this comment.
Nice work. LGTM!
Met betrekking tot de code scanning punten, dat lijkt me inderdaad geen probleem. Die kan je wat mij betreft dismissen
pstokkink
requested changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Knopje om in te loggen met Entra ID toegevoegd, naast het knopje om in te loggen met Keycloak
De werking van de tokens: met het knopje wordt je naar de inlogpagina verwezen (van Entra of Keycloak). Als je succesvol inlogt, wordt je deredirect naar de originele pagina en wordt het verkregen token opgeslagen in de local storage, en op de /v1 pagina toegevoegd aan de headers.
Als je een niet-openbare tabel wil exporteren, wordt er gecheckt of er een token in de local storage staat. Zo ja, dan wordt de export download gestart. Als het token in de local storage verlopen is, wordt er automatisch een call gedaan naar de auth provider van dit vorige token om het te verlengen. Als dat lukt, wordt de export download gestart. Als er helemaal geen token in de local storage staat, verschijnt er een banner met de 2 authorize knopjes. Nadat er op 1 van deze knopjes is geklikt en het inloggen goed ging, wordt de export download gestart.