WIP - Basic webmention support#39
Open
vikanezrimaya wants to merge 5 commits intoAngeloStavrow:masterfrom
Open
WIP - Basic webmention support#39vikanezrimaya wants to merge 5 commits intoAngeloStavrow:masterfrom
vikanezrimaya wants to merge 5 commits intoAngeloStavrow:masterfrom
Conversation
Add configuration for endpoints.
This thing needs jQuery. Probably can be simplified to not include it.
This could probably get removed if I port comment section to vanilla JS. But for now let's go with that. It's cached anyway probably, everyone uses jQuery, right?
Owner
|
Thanks so much for submitting this PR! I've opened #40 for some additional tracking and will start reviewing your changes. |
Owner
|
I've added |
Owner
|
So this is taking a lot longer than I expected, as I learn about the intricacies of webmentions myself. One thing that I'm wondering is if it's worth downloading the whole jQuery library if we're only really interested in |
Author
|
One thing that I'm wondering is if it's worth downloading the whole jQuery library if we're only really interested in `$.getJson()` — most modern browsers support ES6's [`fetch()`](https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch), which might be a little more lightweight (IE doesn't support it, so we might need a polypill there).
See [youmightnotneedjquery.com](http://youmightnotneedjquery.com/) for
some tips on how to replace jQuery and even remain compatible with some
reasonably recent versions of IE.
But seriously, I think alsmot nobody uses IE anymore.
Also CDN requests should be cached in browsers, if I understand it
properly, so I don't think jQuery requirement should be a problem for
most users. But don't count on my knowledge for this since I'm not sure.
|
|
About 88% of users can use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Was discussed in email with repo owner. [Angelo: Issue #40 opened to track this]
Issue mentioned in post: https://fireburn.ru/post/why-my-site-looks-as-it-does/
Dependency Changes
Added jQuery. Can be removed if someone bothers to port comment section in single.html to vanilla JS.
Testing
Additional context
Like buttons are not included because: