Conversation
AngeloStavrow
left a comment
AngeloStavrow
left a comment
There was a problem hiding this comment.
Thanks for submitting this PR! I really appreciate it.
My familiarity with feed auto-discovery is pretty minimal, so I have a question — how would this change affect a feed reader looking for an index.xml file on a path where no such file exists?
My gut tells me that we should provide such metadata only those paths that have an associated index.xml file, like /tags, /catgeories, and whatever's in the site.Params.mainSections array.
| <link rel="feed" type="application/rss+xml" href="./index.xml" title="{{ .Title }}" /> | ||
| <link rel="alternate" type="application/rss+xml" href="./index.xml" title="{{ .Title }}" /> |
There was a problem hiding this comment.
I like that using ./index.html will allow for feed auto-discovery of /posts/index.xml, /tags/index.xml, etc.
Should there be some additional logic would be useful here to make sure that we exclude, for example, /pages/2 (which doesn't have an associated index.xml file)?
There was a problem hiding this comment.
ideally, yes, It'd be better to only include a link where present. I don't know how to do that.
2 participants
Fixes #82