Skip to content

fix: validate upload proxy target URL to prevent SSRF abuse #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MD-Mushfiqur123 wants to merge 1 commit into
base: main
Choose a base branch
from
+36 −0
Open

fix: validate upload proxy target URL to prevent SSRF abuse #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions app/api/upload-binary/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
import { NextResponse } from 'next/server';

// Disallow internal/reserved IP ranges to prevent SSRF abuse of the proxy.
const INTERNAL_HOST_RE = /^(127\.|10\.|172\.(1[6-9]|2[0-9]|3[01])\.|192\.168\.|169\.254\.|0\.|::1|localhost)/i;

function isUnsafeTarget(url) {
try {
const parsed = new URL(url);
if (parsed.protocol !== 'https:') return true;
if (INTERNAL_HOST_RE.test(parsed.hostname)) return true;
return false;
} catch {
return true;
}
}

export async function POST(request) {
try {
const formData = await request.formData();
Expand All @@ -11,6 +25,10 @@ export async function POST(request) {
return NextResponse.json({ error: 'Missing proxy target URL' }, { status: 400 });
}

if (isUnsafeTarget(targetUrl)) {
return NextResponse.json({ error: 'Invalid or unsafe proxy target URL' }, { status: 400 });
}

// Reconstruct the FormData for S3 (excluding our internal proxy marker)
const s3FormData = new FormData();

Expand Down
18 changes: 18 additions & 0 deletions app/api/v1/upload-binary/route.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,19 @@
import { NextResponse } from 'next/server';

// Disallow internal/reserved IP ranges to prevent SSRF abuse of the proxy.
const INTERNAL_HOST_RE = /^(127\.|10\.|172\.(1[6-9]|2[0-9]|3[01])\.|192\.168\.|169\.254\.|0\.|::1|localhost)/i;

function isUnsafeTarget(url) {
try {
const parsed = new URL(url);
if (parsed.protocol !== 'https:') return true;
if (INTERNAL_HOST_RE.test(parsed.hostname)) return true;
return false;
} catch {
return true;
}
}

export async function POST(request) {
try {
const formData = await request.formData();
Expand All @@ -11,6 +25,10 @@ export async function POST(request) {
return NextResponse.json({ error: 'Missing proxy target URL' }, { status: 400 });
}

if (isUnsafeTarget(targetUrl)) {
return NextResponse.json({ error: 'Invalid or unsafe proxy target URL' }, { status: 400 });
}

const s3FormData = new FormData();
for (const [key, value] of formData.entries()) {
if (key !== 'x-proxy-target-url') {
Expand Down