fix: resolve 1 bugs in MicroAI-Paygate - #395
Conversation
|
Someone is attempting to deploy a commit to the ankanmisra's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe wallet widget now catches rejected ChangesWallet widget error handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.5)web/src/components/wallet-widget.tsxFile contains syntax errors that prevent linting: Line 263: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/src/components/wallet-widget.tsx`:
- Around line 262-263: Fix the promise chain in the Promise.all flow so the
.catch handler is syntactically attached directly to the Promise.all(...)
expression before its terminating semicolon. Preserve the existing error logging
through console.error and ensure the wallet widget parses and builds
successfully.
- Around line 262-263: Add a unit test covering the rejected initialization path
in the Promise.all flow around getCurrentAccount and getCurrentChainId,
asserting that rejection logs the expected "Promise.all failed:" message. Keep
the existing rejection behavior unchanged, and run the web lint, typecheck,
test, and build checks.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: bbe031f7-81eb-4a8c-b223-cb465ae61862
📒 Files selected for processing (1)
web/src/components/wallet-widget.tsx
|
|
||
| .catch(err => console.error("Promise.all failed:", err)); No newline at end of file |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Attach .catch to the Promise.all expression.
Line 263 starts a standalone .catch(...) expression. Biome reports a parse error, so this file cannot pass linting or build. Keep the Promise.all(...) expression open and chain .catch(...) before its terminating semicolon.
🧰 Tools
🪛 Biome (2.5.5)
[error] 263-263: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'.
(parse)
🪛 GitHub Actions: Web Lint & Build / 0_web-lint-build.txt
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🪛 GitHub Actions: Web Lint & Build / web-lint-build
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/components/wallet-widget.tsx` around lines 262 - 263, Fix the promise
chain in the Promise.all flow so the .catch handler is syntactically attached
directly to the Promise.all(...) expression before its terminating semicolon.
Preserve the existing error logging through console.error and ensure the wallet
widget parses and builds successfully.
Source: Linters/SAST tools
📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
cd web
bun run lint
bun run typecheck
bun run test:unit
bun run buildRepository: AnkanMisra/MicroAI-Paygate
Length of output: 205
🏁 Script executed:
bun run lint
bun run typecheck
bun run test:unit
bun run buildRepository: AnkanMisra/MicroAI-Paygate
Length of output: 316
🏁 Script executed:
bun run lint
bun run typecheck
bun run test:unit
bun run buildRepository: AnkanMisra/MicroAI-Paygate
Length of output: 316
Add a test for the rejected initialization path.
Promise.all([getCurrentAccount(), getCurrentChainId()]) handles rejection by logging "Promise.all failed:"; if that behavior changes, add a unit test for it. Run lint/typecheck/test/build requirements from web.
🧰 Tools
🪛 Biome (2.5.5)
[error] 263-263: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'.
(parse)
🪛 GitHub Actions: Web Lint & Build / 0_web-lint-build.txt
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🪛 GitHub Actions: Web Lint & Build / web-lint-build
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/components/wallet-widget.tsx` around lines 262 - 263, Add a unit test
covering the rejected initialization path in the Promise.all flow around
getCurrentAccount and getCurrentChainId, asserting that rejection logs the
expected "Promise.all failed:" message. Keep the existing rejection behavior
unchanged, and run the web lint, typecheck, test, and build checks.
Source: Coding guidelines
2 participants
Description
This PR fixes real bugs found in the codebase:
Promise.all: an unhandled rejection in any input promise previously crashed silently.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #394
Note
Catch unhandled promise rejections in
wallet-widget.tsxAdds a
.catchhandler to thePromise.allchain in wallet-widget.tsx so rejections are logged toconsole.errorwith the prefix"Promise.all failed:"instead of remaining unhandled.Macroscope summarized 228d97c.
Summary by CodeRabbit