fix: resolve 1 bugs in MicroAI-Paygate - #397
Conversation
|
Someone is attempting to deploy a commit to the ankanmisra's projects Team on Vercel. A member of the Team first needs to authorize it. |
📝 WalkthroughWalkthroughThe wallet widget now logs failures when its ChangesWallet error handling
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.6)web/src/components/wallet-widget.tsxFile contains syntax errors that prevent linting: Line 263: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@web/src/components/wallet-widget.tsx`:
- Around line 262-263: Fix the Promise.all chain in the wallet widget by
attaching the catch handler directly to the Promise.all(...) expression before
the terminating semicolon. Preserve the existing error message and promise
arguments while ensuring the expression parses correctly.
- Around line 262-263: Add a Web regression test covering the Promise.all
rejection path associated with the catch handler in wallet-widget.tsx, using a
deliberately rejected input while awaiting or otherwise handling the resulting
promise so no unhandled rejection remains. Verify the test exercises the
“Promise.all failed” path, then run lint, typecheck, unit tests, and build from
the web workspace.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: e09950d6-1dd8-4b70-a457-1d58dd2c7a42
📒 Files selected for processing (1)
web/src/components/wallet-widget.tsx
|
|
||
| .catch(err => console.error("Promise.all failed:", err)); No newline at end of file |
There was a problem hiding this comment.
🎯 Functional Correctness | 🔴 Critical | ⚡ Quick win
Fix the Promise.all chaining syntax before merge.
As written, line 263 starts with .catch(...) as a separate statement. Biome reports this as a parse error. Attach .catch(...) directly to the Promise.all(...) expression before its terminating semicolon.
Promise.all(/* existing promises */)
.catch(err => console.error("Promise.all failed:", err));🧰 Tools
🪛 Biome (2.5.6)
[error] 263-263: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'.
(parse)
🪛 GitHub Actions: Web Lint & Build / 0_web-lint-build.txt
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🪛 GitHub Actions: Web Lint & Build / web-lint-build
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/components/wallet-widget.tsx` around lines 262 - 263, Fix the
Promise.all chain in the wallet widget by attaching the catch handler directly
to the Promise.all(...) expression before the terminating semicolon. Preserve
the existing error message and promise arguments while ensuring the expression
parses correctly.
Source: Linters/SAST tools
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n 'WalletWidget|Promise\.all failed|Promise\.all' web --glob '*.{test,spec}.{ts,tsx}'Repository: AnkanMisra/MicroAI-Paygate
Length of output: 164
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n 'WalletWidget|Promise\.all failed|Promise\.all' web --glob '*.{test,spec}.{ts,tsx}'Repository: AnkanMisra/MicroAI-Paygate
Length of output: 164
🏁 Script executed:
#!/bin/bash
set -euo pipefail
rg -n 'WalletWidget|Promise\.all failed|Promise\.all' web --glob '*.{test,spec}.{ts,tsx}'Repository: AnkanMisra/MicroAI-Paygate
Length of output: 164
Add a regression test for rejected inputs.
No current Web test covers one Promise.all input rejecting or the Promise.all failed handler running. Add a Web test that exercises the rejection path without leaving an unhandled rejection.
Then run bun run lint, bun run typecheck, bun run test:unit, and bun run build from web.
🧰 Tools
🪛 Biome (2.5.6)
[error] 263-263: Expected a statement but instead found '.catch(err => console.error("Promise.all failed:", err))'.
(parse)
🪛 GitHub Actions: Web Lint & Build / 0_web-lint-build.txt
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🪛 GitHub Actions: Web Lint & Build / web-lint-build
[error] 263-263: ESLint parsing error: Declaration or statement expected. The 'bun run lint' command failed with exit code 1.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@web/src/components/wallet-widget.tsx` around lines 262 - 263, Add a Web
regression test covering the Promise.all rejection path associated with the
catch handler in wallet-widget.tsx, using a deliberately rejected input while
awaiting or otherwise handling the resulting promise so no unhandled rejection
remains. Verify the test exercises the “Promise.all failed” path, then run lint,
typecheck, unit tests, and build from the web workspace.
Source: Coding guidelines
2 participants
Description
This PR fixes real bugs found in the codebase:
Promise.all: an unhandled rejection in any input promise previously crashed silently.Type of Change
How Has This Been Tested?
Checklist
Related Issue
Ref: #396
Note
Catch unhandled promise rejections in
wallet-widget.tsxAdds a
.catchhandler to thePromise.allchain in wallet-widget.tsx so rejections are logged toconsole.errorwith the prefix"Promise.all failed:"instead of remaining unhandled.Macroscope summarized 3ffa780.
Summary by CodeRabbit