fix: allow serve() to detect any entry point function name#829
Open
thecaptain789 wants to merge 1 commit intoAnswerDotAI:mainfrom
Open
fix: allow serve() to detect any entry point function name#829thecaptain789 wants to merge 1 commit intoAnswerDotAI:mainfrom
thecaptain789 wants to merge 1 commit intoAnswerDotAI:mainfrom
Conversation
Fixes AnswerDotAI#816. The serve() function previously required the calling function to be named exactly 'main'. This removes that restriction so entry points with any name (e.g., 'start', 'run_app') work correctly.
|
Review these changes at https://app.gitnotebooks.com/AnswerDotAI/fasthtml/pull/829 |
Contributor
|
This is an nbdev project so changes need to be made in the ipynb files, then exported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #816.
The
serve()function previously required the calling function to be named exactly'main'. This restriction is unnecessary since the key check is whether we're running from__main__, not the function name.Before: Entry points like
myapp:start_appwould fail silently.After: Any function name works as long as it's called from
__main__.Changes:
code.co_name=='main'check from appname detectioncodevariable