Kt/himactestingv2 #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we don't have all the debug statements when trying to do himac testing
…ric-Racing/embedded into kt/himactestingv2
Deploying embedded with
|
| Latest commit: |
1a56f02
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://82e6fc9c.embedded-ah0.pages.dev |
| Branch Preview URL: | https://kt-himactestingv2.embedded-ah0.pages.dev |
The previous order was resulting in "constrain not defined" error, this should fix that issue
Cpp-Linter Report
|
Added some lines to Utils.h and tinkered around with APPS code aswell. Slight fixes towards adc code as well as APPS header. Comments written where changes were implemented. (Anoop && Dylan)
Faults are set and cleared from main.cpp
…ric-Racing/embedded into kt/himactestingv2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Updated the motor state machine to match inverter.
Why the change is needed and implementation details
It is needed to test proper functionality of the inverter at HIMaC.
Testing and validation
TBD at HIMaC (logic flow verified)