qcow2: drivers: fix memory leak in qcow2 on multiple open/close#3
Open
guzu wants to merge 1 commit intoAnthoineB:v3.55.5-qcow2from
Open
qcow2: drivers: fix memory leak in qcow2 on multiple open/close#3guzu wants to merge 1 commit intoAnthoineB:v3.55.5-qcow2from
guzu wants to merge 1 commit intoAnthoineB:v3.55.5-qcow2from
Conversation
When doing pause/unpause there was a memory leak related to coroutine stack when coroutine pool are used (CONFIG_COROUTINE_POOL). Code using QEMU threads can register a callback at thread exit, and QEMU coroutine have local_pool_cleanup() registered for that. We just have to use QEMU threads instead of standard pthreads to free the stack coroutine memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When doing pause/unpause there was a memory leak related to coroutine stack when coroutine pool are used (CONFIG_COROUTINE_POOL).
Code using QEMU threads can register a callback at thread exit, and QEMU coroutine have local_pool_cleanup() registered for that. We just have to use QEMU threads instead of standard pthreads to free the stack coroutine memory.