Open
Conversation
61ab030 to
3dc15e7
Compare
c9deed3 to
dc26d5b
Compare
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
dc26d5b to
16f2a82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
suite-test-namechecker that enforces naming consistency between testify suite structs and their runner functions.Rule
Runner function must be named
Test<SuiteName>:Supports both
new(SuiteName)and&SuiteName{}instantiation forms. Autofix renames the function identifier.Enabled by default: false — pure style unification
Autofix: true
Changes
internal/checkers/suite_test_name.go—AdvancedCheckerusinginspector.WithStackto findsuite.Runcalls, extract suite type name, and validate the enclosing function nameinternal/checkers/checkers_registry.go— registered withenabledByDefault: falseinternal/testgen/gen_suite_test_name.go+internal/testgen/main.go— test generator with errored/golden templatesanalyzer/testdata/src/checkers-default/suite-test-name/— generated test datainternal/checkers/checkers_registry_test.go,analyzer/checkers_factory_test.go— updated expected checker listsREADME.md— checker documented in table and checkers sectionCONTRIBUTING.md— removed from "Open for contribution"Closes #48