Draft
Conversation
- Added SD ingress logs for received service discovery traffic, including sender and whether it arrived via multicast or unicast. - Expanded SD offer logs so accepted offers and ignored offers include the concrete reason and endpoint context. - Added subscription lifecycle logs for: - SD subscribe send - SD unsubscribe send - remote subscribe receive - remote unsubscribe receive - subscribe ACK - subscribe NACK - Added application-side availability transition logs, including when subscription state is reset because a service became unavailable. - Added debug logs for incoming remote SOME/IP responses and errors with source IP, port, and transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds explanatory vSomeIP logs to make SOME/IP and SOME/IP-SD debugging easier without changing behavior or configuration.
The focus is the event-driven v1 scope from the issue discussion: log what vSomeIP already knows at the point where it accepts, ignores, acknowledges, rejects, or receives something, instead of introducing new persistent state.
What Changed
Why
This is meant to answer the common debugging questions from the issue more directly, for example:
Scope / Non-Goals
Verification
git diff --checkimplementation/service_discovery/src/service_discovery_impl.cpp.oimplementation/routing/src/routing_manager_impl.cpp.oimplementation/routing/src/routing_manager_client.cpp.oimplementation/runtime/src/application_impl.cpp.o