Add ConnectAsync and InitializeAsync methods to TCP clients#148
Open
rowan-walsh wants to merge 2 commits intoApollo3zehn:devfrom
Open
Add ConnectAsync and InitializeAsync methods to TCP clients#148rowan-walsh wants to merge 2 commits intoApollo3zehn:devfrom
rowan-walsh wants to merge 2 commits intoApollo3zehn:devfrom
Conversation
The T4 *.tt templates were slightly out-of-date after the namespace indentation changes.
Added for ModbusRtuOverTcpClient and ModbusTcpClient, using the .tt templates. Includes tests of Connect/Init cancellation tokens or timeouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the *.tt templates to add translated ConnectAsync and InitializeAsync methods for
ModbusTcpClientandModbusRtuOverTcpClient. Seemed like an easy win because the non-async Initialize methods were already usingtcpClient.ConnectAsync(...)internally.