Open
Conversation
|
Shouldn't the response be ignored if the transaction id is different, instead of throwing an exception? Throwing will result in no data being read and thus data loss. |
Author
|
The data loss will also occur, if we just ignore the response. With an exception at least we know about that and also reconnection could happen. |
|
It would require a larger change, but you could keep in memory the responses for the different transaction id's, waiting until the response for "your" id is received, and then continue. Out of order responses are a part of the protocol, so this does not indicate a "bad" connection, so a reconnect is not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a fix for the #146 issue. If the two transaction ID is the same, it throws an error and rebuilds the connection.