fix ros::master::getTopics() getting worng results #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The declaration of ros::master::getTopic says that each item in the result of ros::master::getTopics should be a pair <string topic, string type>, but in the implement the item is a pair of <string topic, string uri> which is conflict with declaration.
|
|
Eddy-W
added a commit
to Eddy-W/apollo-platform
that referenced
this pull request
Jul 26, 2019
The declaration of ros::master::getTopic says that each item in the result of ros::master::getTopics should be a pair <string topic, string type>, but in the implement the item is a pair of <string topic, string uri> which is conflict with declaration. ref:[ApolloAuto#65]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The declaration of ros::master::getTopic says that each item in the result is a pair <string topic, string type>, but in the implementation the item is a pair of <string topic, string uri> which is conflict with declaration.
Besides, the TopicInfo is a container of topic name and datatype, not uri