Update libsquashfuse and add support for Zstd #196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure they will be linked into the binary in the appropriate order. Also, it saves a few lines of code elsewhere when linking against libsquashfuse.
This update allows us to remove all the patches and makes the configuration step a lot easier, too.
Distros dropped i386 years ago.
This was referenced Nov 25, 2024
Member
|
Why was i386 dropped here? |
probonopd
reviewed
Nov 25, 2024
|
|
||
| # special builds | ||
| - DIST: bionic | ||
| - RELEASE: latest |
Member
There was a problem hiding this comment.
Pinning is recommended, because "latest" is a moving target and may break anytime.
| - RELEASE: latest | ||
| ARCH: x86_64 | ||
| - DIST: bionic | ||
| ARCH: i386 |
Member
There was a problem hiding this comment.
Is there a technical necessity to drop this?
| # store repo root as variable | ||
| REPO_ROOT="$(readlink -f "$(dirname "$(dirname "$0")")")" | ||
| OLD_CWD="$(readlink -f .)" | ||
| REPO_ROOT="$(readlink -f "$(dirname "$(dirname "${BASH_SOURCE[0]}")")")" |
Member
There was a problem hiding this comment.
I always try to use POSIX instead of bashisms. (But then, I try to get away from GNU)
|
|
||
| # we need Boost.Algorithm, which does not need to be included explicitly since it's header-only | ||
| # link to Boost::boost to include the header directories | ||
| find_package(Boost 1.53.0 REQUIRED) |
Member
There was a problem hiding this comment.
Are desktops such as KDE using Boost? Most likely they are not thrilled about this dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also removes a lot of old and now obsolete patching and removes the option of building libarchive, liblzma etc. right from CMake.