ci: publish helm chart to GHCR and Docker Hub#3
Merged
Conversation
agaffney
requested changes
May 5, 2025
.github/workflows/publich
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: ['main'] |
There was a problem hiding this comment.
I'm not sure that we want to trigger on push to master. This would allow accidental overwrite of a previously published version if a commit it merged without the version being bumped in the chart
There was a problem hiding this comment.
"publish" (spelling), and this should have a .yml extension
verbotenj
force-pushed
the
ci/publish-helm-chart
branch
8 times, most recently
from
70dcc62 to
dcefd4f
Compare
- update PR GHA to test lint, version check and install Signed-off-by: Ales Verbic <averbic@applause.com>
verbotenj
force-pushed
the
ci/publish-helm-chart
branch
from
dcefd4f to
d5638cd
Compare
agaffney
approved these changes
May 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]