Skip to content

Conversation

@ethanneff
Copy link

Problem

Linting was working in 6.17.1, but broken by 6.17.8

Screenshot 11

Solution

The declare module block is sufficient; the duplicate ambient declarations were unnecessary and caused the issue.
What was happening:

  • The declare module "react-native-appsflyer" block (lines 12-417) defines all the types correctly
  • The ambient declarations at the bottom were duplicates that originally used any types, causing the linting errors
  • TypeScript and ESLint work fine with just the declare module block

Why the original code had both:
The comment mentioned "ESLint's import resolver doesn't recognize exports inside 'declare module' blocks," but modern ESLint with TypeScript support handles this correctly. The ambient declarations were redundant and introduced the any type problem.

Removed explicit ambient declarations for ESLint compatibility.
Copilot AI review requested due to automatic review settings January 7, 2026 20:32
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ethanneff
Copy link
Author

should resolve #649

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant