feat: add SelectPreference component#2091
Merged
AprilSylph merged 1 commit intomasterfrom Feb 6, 2026
Merged
Conversation
marcustyphoon
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CheckboxPreferencecomponent #2055TextPreferencecomponent #2075TextAreaPreferencecomponent #2086ColorPreferencecomponent #2089Creates a
SelectPreferenceElementclass andSelectPreferenceshorthand function, for rendering colour-type preferences.Like previous preference components, this PR does not implement any usages of the component, just the component itself.
This one was fun, because I found out that setting
HTMLSelectElement.valuedoes actually work, provided it matches thevalueof one of the<option>elements. I've opted to keep the code simple by leveraging this, which does come at the cost of component instances needing to setoptionsbefore setting its ownvalue, but I think that's fine—the JSdoc already says thatvaluemust match one of theoptions.Testing steps