Replace \u0000 with space in web ui#136
Open
imerr wants to merge 1 commit intoArchiveTeam:developmentfrom
Open
Replace \u0000 with space in web ui#136imerr wants to merge 1 commit intoArchiveTeam:developmentfrom
imerr wants to merge 1 commit intoArchiveTeam:developmentfrom
Conversation
These apparently show up in as a spacer betweeen items and break copy&pasting in firefox (chrome works fine)
Member
Author
|
Oops, partial dupe of #133, but this one also replaces \0 in the output log |
Member
Author
|
Here's the firefox bug report, might be a mix of os copy api limitation and bad \0 handling in chrome too https://bugzilla.mozilla.org/show_bug.cgi?id=1818910 |
Member
|
I am slightly concerned about items would contain a space themselves. There is no clear distinction in the logs between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These apparently show up in as a spacer betweeen items and break copy&pasting in firefox (chrome works fine)
As an alternative to space it could also use \u2400 which is "symbol for null" (␀), but I think for display purposes a space is perfectly acceptable (and less confusing than ␀)