-
Notifications
You must be signed in to change notification settings - Fork 4
Custom 404 and 505 pages #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…into review-cam-add-bio-toworkers-forms
… review-cam-org-view
…to review-cam-shiftfilled
… review-cam-linkorg-frmshifts
|
Hey @Timilehin08 , thanks for requesting review! But I'm also getting an odd message when I go to organizations#show for an org id that doesn't exist. This used to trigger rails' built-in 404 page but now looks like this. |
|
@Timilehin08 Hey Timi! Please resolve the conflicts, and I will review the work you've done. Seeing as 25 files have been changed (😅 ) I think that high number is due to the conflicts. |
|
Hello @aritamana @ncbui @saradotlog @GabrielleEaston I resolved the conflicts already. A large part of The files changed is due to the my branch not been as recent as the main but apart from that, the conflicts have been resolved with main. I however still have issues with the 500 page showing the correct error message given. i tried to break the app and it showed the 500 error but not the styling and message put in the html folder. |
|
Hello @aritamana @ncbui @saradotlog @GabrielleEaston I resolved the conflicts already. A large part of The files changed is due to the my branch not been as recent as the main but apart from that, the conflicts have been resolved with main. I however still have issues with the 500 page showing the correct error message given. i tried to break the app and it showed the 500 error but not the styling and message put in the html folder. |
|
Hello @aritamana. Been on this since Thursday and I have to close this PR as it became way too difficult to resolve conflicts on that branch despite using git rebase --main into the branch. It was adding way more commits, almost 170, and not rebasing properly even after a conflict has been resolved. This is why i decided to create another branch today and PR which is #116. |


What type of PR is this? (check all applicable)
Description of what PR does
rails g controller errors not_found internal_server_error.config/routes.rb.application.rbfile.config/environments/development.rbin order to test things out locally.app/views/errorsaccordingly.Related PRs and/or Issues (if any)
QA Instructions, Screenshots, Recordings
For example, go to http://127.0.0.1:3000/sss to see how error page looks like.
https://web-crunch.com/posts/custom-error-page-ruby-on-rails
Added tests?
Added to documentation?