Skip to content

Added size metrics#33

Merged
scx1332 merged 4 commits intomainfrom
scx1332/add_missing_metrics
Mar 9, 2026
Merged

Added size metrics#33
scx1332 merged 4 commits intomainfrom
scx1332/add_missing_metrics

Conversation

@scx1332
Copy link
Member

@scx1332 scx1332 commented Mar 9, 2026

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds payload-size (“bytes processed”) metrics to the SQLite-backed Arkiv store’s event follower so operators can observe data volume in addition to operation counts.

Changes:

  • Register new go-ethereum counters for create/update/delete payload bytes.
  • Track per-block byte totals for create/update/delete operations while processing events.
  • Emit the new byte totals in batch logging and increment the new metrics alongside existing per-block counters.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This comment was marked as resolved.

@scx1332 scx1332 requested a review from Copilot March 9, 2026 14:55
@scx1332 scx1332 self-assigned this Mar 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

sqlitestore.go:550

  • metricOwnerChanges.Inc(int64(stat.ownerChanges)) is now doing an unnecessary and inconsistent cast since ownerChanges is already tracked as int64 (same as the other counters in this loop). Consider passing stat.ownerChanges directly for consistency and to avoid redundant conversions.
					if stat.ownerChanges > 0 {
						metricOwnerChanges.Inc(int64(stat.ownerChanges))
					}

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@draganm draganm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a try

@scx1332 scx1332 merged commit 652b0b2 into main Mar 9, 2026
5 checks passed
@scx1332 scx1332 deleted the scx1332/add_missing_metrics branch March 9, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants