Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds payload-size (“bytes processed”) metrics to the SQLite-backed Arkiv store’s event follower so operators can observe data volume in addition to operation counts.
Changes:
- Register new go-ethereum counters for create/update/delete payload bytes.
- Track per-block byte totals for create/update/delete operations while processing events.
- Emit the new byte totals in batch logging and increment the new metrics alongside existing per-block counters.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
sqlitestore.go:550
metricOwnerChanges.Inc(int64(stat.ownerChanges))is now doing an unnecessary and inconsistent cast sinceownerChangesis already tracked asint64(same as the other counters in this loop). Consider passingstat.ownerChangesdirectly for consistency and to avoid redundant conversions.
if stat.ownerChanges > 0 {
metricOwnerChanges.Inc(int64(stat.ownerChanges))
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.