fix: duplicated exit window #2802
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arufonsu
commented
Jan 17, 2026
Arufonsu
commented
- fixes duplication of exit confirmation window behavior across the game client
Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>
Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>
pandinocoder
requested changes
Jan 31, 2026
Comment on lines
57
to
63
| Closed += OnWindowClosed; | ||
| } | ||
|
|
||
| private void OnWindowClosed(Base sender, EventArgs args) | ||
| { | ||
| // Trigger the cancel handler when window is closed via X button | ||
| _handleCancel?.Invoke(this, args); |
Member
There was a problem hiding this comment.
This should be in InputBox
| userData: userData | ||
| ) | ||
| { | ||
| _handleCancel = handleCancel; |
| public class AlertWindow : InputBox | ||
| { | ||
| private static readonly HashSet<AlertWindow> _instances = []; | ||
| private readonly GwenEventHandler<EventArgs>? _handleCancel; |
Member
There was a problem hiding this comment.
Not needed. If this was done in InputBox (where it belongs), Cancelled can and should already be emitted from there
| private void OnWindowClosed(Base sender, EventArgs args) | ||
| { | ||
| // Trigger the cancel handler when window is closed via X button | ||
| _handleCancel?.Invoke(this, args); |
Member
There was a problem hiding this comment.
This would be invoking Cancelled from InputBox
(tested: working as intended) Signed-off-by: Arufonsu <17498701+Arufonsu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.