Skip to content

final edits to my portfolio#14

Open
Asel-K wants to merge 1 commit into
mainfrom
lesson-7
Open

final edits to my portfolio#14
Asel-K wants to merge 1 commit into
mainfrom
lesson-7

Conversation

@Asel-K
Copy link
Copy Markdown
Owner

@Asel-K Asel-K commented Jul 21, 2021

No description provided.

Copy link
Copy Markdown

@ckesurf ckesurf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave a glowing review on your final project, Asel. Great job, keep up the good work, and good luck on your new pursuit as a stellar front-end dev.

Comment thread js/index.js

let messageForm=document.getElementsByName('leave_message')
leave_message.addEventListener('submit',function(e){
leave_message.addEventListener('submit',(e)=>{
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using arrow functions! expertly done

Comment thread index.html
</a>

<!-- <a href = "mailto:asel.karagazieva@gmail.com" target="_blank" class = "icon"> -->
<a href = "mailto:asel.karagazieva@gmail.com" target="_blank" class = "icon">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using the target=_blank to open in new tab, expertly done

Comment thread css/index.css
#messages a {
display: inline-block;
width: 30%;
width: fit-content;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Comment thread css/index.css
background-image: url(../css/blue\ grey.jpg);
background-size: cover;
background-blend-mode: multiply;
color: var(--clr-light);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the messages section looks very stylish in browser. great job here.

Comment thread js/index.js
let messageSection = document.getElementById("messages");
let messageList = messageSection.querySelector('ul')

let removeButton= document.createElement("button")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this whole section looks cleaner. If I had anything nitpicky to say, it would be that some lines in this section, like 61 through 64, could be indented, and it would be nice to see consistent semicolons at the end of code statements, especially because you worked hard to break up certain lines so they could be more readable, such as in Line 56-57, which I appreciate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants