Feature/cep 59/clean configs setup#6
Conversation
AshenScribe
force-pushed
the
feature/cep-59/clean-configs-setup
branch
from
0b47d31 to
a172e61
Compare
AshenScribe
force-pushed
the
feature/cep-59/clean-configs-setup
branch
2 times, most recently
from
60df719 to
ea7863b
Compare
|
What's the status of this PR? Is this ready for review? |
|
@SiyaoIsHiding yes |
SiyaoIsHiding
left a comment
SiyaoIsHiding
left a comment
There was a problem hiding this comment.
Did you run all integration tests with all tests passing?
Did you manually setup a Cassandra cluster with a different graceful_disconnect_grace_period: 6000 in cassandra.yaml and made sure getGracefulDisconnectGracePeriod actually gets 6000?
Code looks good. It would be great if you describe what testing you did.
|
|
||
| # Enable or disable graceful disconnect. When false, shutdown behavior is | ||
| # unchanged from previous versions. | ||
| graceful_disconnect_enabled: true |
There was a problem hiding this comment.
I thought we agreed that it would be disabled by default in the first release?
| @@ -0,0 +1,158 @@ | |||
| # Graceful Disconnect — In-Band Connection Draining for Cassandra Node Shutdown | |||
|
|
|||
There was a problem hiding this comment.
This markdown file shouldn't be here
There was a problem hiding this comment.
Such documentation can be added to the manual, after we finish the implementation.
There was a problem hiding this comment.
e.g. doc/modules/cassandra/pages/managing/operating/
Explicitly set public visibility for graceful disconnect getter and setter methods in StorageServiceMBean to ensure consistent JMX accessibility.
AshenScribe
force-pushed
the
feature/cep-59/clean-configs-setup
branch
from
ea7863b to
3751ceb
Compare
|
@SiyaoIsHiding
|
| # See: org.apache.cassandra.transport.GracefulShutdown.md | ||
|
|
||
| # Enable or disable graceful disconnect. When false, shutdown behavior is | ||
| # unchanged from previous versions. |
There was a problem hiding this comment.
mention what the default is (when it's commented out)
|
|
||
| # Enable or disable graceful disconnect. When false, shutdown behavior is | ||
| # unchanged from previous versions. | ||
| # graceful_disconnect_enabled: false |
AshenScribe
force-pushed
the
feature/cep-59/clean-configs-setup
branch
4 times, most recently
from
a83d38e to
57a49d1
Compare
AshenScribe
force-pushed
the
feature/cep-59/clean-configs-setup
branch
from
57a49d1 to
6923871
Compare
…nnect_grace_period(earlier 30s) to true and 5s respectively
AshenScribe
force-pushed
the
feature/cep-59/clean-configs-setup
branch
from
6923871 to
fac977e
Compare
3 participants
https://issues.apache.org/jira/browse/CASSANDRA-21203