Merged
Conversation
- Document HF_ENDPOINT environment variable usage in README - Move ensure_trailing_slash to module-level function - Use HF_ENDPOINT from env with fallback to hf-mirror.com - Clean up LargeFileInformation constructor and formatting - Simplify path stripping in LFS file extraction
- Move base URL constants to new constants module - Replace compile-time `option_env!` with runtime `env::var` for HF_ENDPOINT - Use DEFAULT_BASE_URL constant as fallback - Update all references to use new constants module
remove the trailing slash from the default base url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
ensure_trailing_slashfunction out of the original fn block for better readability and styling.HF_ENDPOINTenvironment variable to alter the originalhf-mirror.comurl.