Fix grab project #17
Open
Fix grab project #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Make internal class D3D10GrabberImpl and move it to cpp. This allows us to hide inplementation details from header. - Set D3D10GrabberImpl class to use smart pointers to hold resources. - Use WinDXUtils module instead of local DX-helper functions.
Contributor
Author
There was a problem hiding this comment.
There is a big diff for this file, but actual changes are not so complex.
Maybe it is so big because line endings were changed to unix LF.
Collaborator
|
Dreamer-dead, could you please write to tim.helloworld@gmail.com to share your contact with me? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a grab project refactoring so it can be compiled with MSVC.
Also I make some fixes like add QScopedPointers insetad of raw * pointers.
This patch should be applied after 'fix-math-project' request because it uses math::round() function.