Skip to content

Conversation

@sentfanwyaerda
Copy link

I provided the res/languages/nl_NL.ts file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be: <TS version="2.0" language="nl_NL">
I made a small boo boo.

@timsat
Copy link
Collaborator

timsat commented Dec 13, 2013

lrelease couldn't parse the translation file:

lrelease error: Parse error at D:/System/Users/Tim/Projects/light-nl/Software/src/../res/translations/nl_NL.ts:97:31: Entity 'euml' not declared.

Thanks for contributing!

@timsat
Copy link
Collaborator

timsat commented Dec 13, 2013

btw Qt5.1.1, Win7

@sentfanwyaerda
Copy link
Author

a well, then &euml; (ë) should be added as an valid entity. The dutch language has some of those 'special' characters.
I assumed it to be "just" only XML and provided the textual document as such. (I don't do Qt or Win7, only translate)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&euml; should be written as ë because it is an unknown entity within the Qt compiler

@DouweM
Copy link

DouweM commented Mar 7, 2014

I apologize for the avalanche of comments, but in my experience a bad translation is more annoying than no translation at all. Your translation is great for the most part, but I think there are some places where it can be improved.

If you don't feel like making all of those changes yourself, the Lightpack folks can just merge this PR and I'll send another one with my proposed changes.

e-yes added a commit that referenced this pull request Jun 24, 2014
Fix compilation with Mac SDK below 10.9 and clear some warnings.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants