Fix memory leaks in validate_function.c - #14
Draft
matapatos wants to merge 1 commit into
Draft
Conversation
- Track field_name ownership with field_name_owned flag - Release field_name consistently in all error paths - Fix add_field_error to use ZVAL_STRINGL and remove redundant dtor - Ensure errors array is always cleaned up on exception paths - Add continue statement after handling missing field_value Closes #1 Co-authored-by: matapatos <matapatos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix memory leaks in validate_function.c
Changes
field_nameownership withfield_name_ownedflag to prevent double-free and memory leaksfield_nameconsistently in all error paths (exception handling, stop_at_first_error, missing fields)add_field_errorto useZVAL_STRINGLinstead ofZVAL_STRING+zval_ptr_dtor(redundant since hash add does its own refcounting)errorsarray is always cleaned up on all exception pathscontinuestatement after handling missingfield_valueto prevent fallthroughImpact
Closes #1