Standardize naming conventions in C code - #21
Closed
matapatos wants to merge 1 commit into
Closed
Conversation
- Add av_ prefix to all internal functions in validate_function.c: - transform_property_name -> av_transform_property_name - get_property_name -> av_get_property_name - get_property_value -> av_get_property_value - add_field_error -> av_add_field_error - validate_field_value -> av_validate_field_value - Standardize all functions to use zend_always_inline - Update const correctness for error_message parameter - Fix add_field_error to use ZVAL_STRINGL and remove redundant dtor - Update all function calls to use new names - Update header file declarations to match Closes #8 Co-authored-by: matapatos <matapatos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize naming conventions in C code
Changes
av_prefix to all internal functions in validate_function.c:transform_property_name→av_transform_property_nameget_property_name→av_get_property_nameget_property_value→av_get_property_valueadd_field_error→av_add_field_errorvalidate_field_value→av_validate_field_valuezend_always_inlineImpact
Closes #8