Aither: fix language requirements

[vmt5m3mjb]

https://aither.cc/pages/1

Foreign content must contain an English dub track, English subtitles, or both

Summary by CodeRabbit

• New Features
  • Added language requirement validation for non-BDMV/DVD media to verify English support in audio and subtitles.
  • Introduced an optional enforcement toggle to require the original-language track be present in audio; if missing, the item is rejected earlier with a clear failure path.

[github-actions]

Thanks for taking the time to contribute to this project. Upload Assistant is currently in a complete rewrite, and no new development is being conducted on this python source at this time.

If you have come this far, please feel free to leave open, any pull requests regarding new sites being added to the source, as these can serve as the baseline for later conversion.

If your pull request relates to a critical bug, this will be addressed in this code base, and a new release published as needed.

If your pull request only addresses a quite minor bug, it is not likely to be addressed in this code base.

Details for the new code base will follow at a later date.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 194ffb2 and b65c282.

📒 Files selected for processing (2)

• src/trackers/AITHER.py
• src/trackers/COMMON.py

---

📝 Walkthrough

Walkthrough

Adds an asynchronous language requirements check call into AITHER.get_additional_checks for non-BDMV/DVD discs. The change causes AITHER to return False immediately when COMMON.check_language_requirements fails (including when the original language requirement is unmet), altering control flow before the existing valid_mi check.

Changes

Cohort / File(s)	Summary
Language requirement logic src/trackers/AITHER.py, src/trackers/COMMON.py	Added an await call to common.check_language_requirements in AITHER.get_additional_checks for non-BDMV/DVD discs and extended COMMON.check_language_requirements with a new original_required: bool parameter that enforces presence of the original language in audio languages and returns False on failure.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor language checks to use common method across trackers #1030: Modifies and uses COMMON.check_language_requirements across trackers; strongly related to this PR's extension and AITHER usage.

Poem

🐰 I hopped through code with careful paws,
A language gate with clear-cut laws,
If original voice is missing, I sigh—
I stop the run, I don’t let it fly.
Hooray for checks that catch the cause! 🎉

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to updating AITHER subtitles requirement, which aligns with the PR objective to update subtitle policy validation. However, the actual change adds a language requirements check (including audio and subtitles), making the title somewhat incomplete.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/trackers/AITHER.py`:
- Around line 29-35: In get_additional_checks, fix the malformed if by adding
the missing colon and a body that enforces the requirement: call await
self.common.check_language_requirements(...) and if it returns False set
should_continue = False (or return False immediately) when meta['is_disc'] is
not in ["BDMV","DVD"]; ensure the await is used and the function returns the
final should_continue (or returns False early) so the check actually blocks
uploads when it fails.

---

ℹ️ Review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df93bbd and 194ffb2.

📒 Files selected for processing (1)

• src/trackers/AITHER.py