Open
Conversation
Contributor
FreshRoyal
commented
Feb 26, 2026
- several changes (details in individual commits)
* starting files * update core.index * change book id
* Add files via upload * Added background ASI grant * Errata * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> --------- Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
) * items, proficiencies, properties, languages and alignments * changed element type from Class Feature to Proficiency * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/items/items-weapons.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update weapon-mastery-properties.xml * Update weapon-mastery-properties.xml * Update weapon-mastery-properties.xml * removed 'Skill' support * Update languages.xml * added info section * Update core/players-handbook-2024/items/items-weapons.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update items-weapons.xml * Apply suggestions from code review * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review * Apply suggestions from code review * added more supports --------- Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
* backgrounds * added requirements to Ability Score Option selections added !ID_INTERNAL_GRANTS_BACKGROUND_ASI requirement to prevent doubled asi selection when using 2024 backgrounds * removed appends and added new background asi options * fixed typos and missing element * all the Feats * Update background-wayfarer.xml * Update background-acolyte.xml * Update background-artisan.xml * Update background-charlatan.xml * Update background-criminal.xml * Update background-entertainer.xml * Update background-farmer.xml * Update background-guard.xml * Update background-guide.xml * Update background-hermit.xml * Update background-merchant.xml * Update background-noble.xml * Update background-sage.xml * Update background-sailor.xml * Update background-scribe.xml * Update background-soldier.xml * Update background-wayfarer.xml * added general feats' and epic boons' ASI elements * moved type="Ability Score Improvement" elements into internal.xml * forgot to change elements source to Internal * moved type="Ability Score Improvement" elements into internal.xml * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * fixed Magic Initiate * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Fix for Resilient Feat * actual fix for Resilient * fixed wrong element type of ASI +2 /+1 options * Update background-acolyte.xml * Update background-guide.xml * Update background-sage.xml * Update background-scribe.xml * Update background-noble.xml * Update background-charlatan.xml * Update feats-general.xml * Update feats-general.xml * Update feats-general.xml * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update background-acolyte.xml * Update background-charlatan.xml * Update background-criminal.xml * Update background-entertainer.xml * Update background-farmer.xml * Update background-guard.xml * Update background-guide.xml * Update background-hermit.xml * Update background-merchant.xml * Update background-noble.xml * Update background-sage.xml * Update background-sailor.xml * Update background-scribe.xml * Update background-soldier.xml * Update background-wayfarer.xml * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update feats-general.xml * Apply suggestions from code review * Update core/players-handbook-2024/feats/feats-origin.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/feats/feats-general.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> --------- Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: aurorabuilderlegacy <73967377+aurorabuilderlegacy@users.noreply.github.com>
* added new files * removed blank files * Revert "added new files" This reverts commit dacbcb7. * added ranger archetypes * added ranger class * a bunch of fixes added missing flavor text, feature replacements and other small fixes * Paladin + subclasses & other changes * corrected typo * corrected typo * corrected wrong supports type * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update ranger-gloom-stalker.xml * added rules for feat selections * added rules for feat selections * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update ranger-gloom-stalker.xml * Implemented Nick's [General] suggestions * Implemented Nick's [General] suggestions * Implemented the rest of Nick's [General] suggestions * Implemented the rest of Nick's [General] suggestions * Update ranger-hunter.xml * Update ranger-gloom-stalker.xml * Update ranger-fey-wanderer.xml * Update paladin-ancients.xml * Update ranger-beast-master.xml * Update paladin-vengeance.xml * Update paladin-glory.xml * Update paladin-devotion.xml * Update paladin-ancients.xml * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> --------- Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
…h Subclasses, Eldritch Invocations, Companions (#280) * Add files via upload * Add files via upload * Update class-sorcerer.xml Removed "prepared spell slots" stats (erroneously copied from PHB2024 wizard file) * Adding Bard class file * Adding Bard subclass files * Adding rogue class * Adding Rogue subclasses * Adding Barbarian class file * Adding Barbarian subclass files * Added Druid and Warlock base classes * Adding Druid and Warlock subclasses * Adding Eldritch Invocations * Update eldritch-invocations.xml Correcting file location in the info block * Added Companions file * Update class-sorcerer.xml Added missing Replacement Feature elements for new PHB2024 features * Update class-bard.xml Added missing Replacement Feature elements for new PHB2024 features * Update druid-land.xml Removed Condition Immunity "Poisoned", as it is not part of the base app. * Update warlock-celestial.xml Corrected lvl 14 feature to be granted @ lvl 14 (was erroneously granted at lvl 10) * Update warlock-archfey.xml Corrected lvl 14 feature to be granted at lvl 14 (was erroneously granted at lvl 10) * Update class-rogue.xml 5d6 Sneak Attack option in class table was erroneously listed as "Sd6" * Uploading newest files to compare to current PR * Uploading new files to compare to current PR * Update class-bard.xml * Updated Replacement Tag names with _24_ marker * Updated Replacement Tag names with _24_ marker * Corrected Typo in Barb Replacement IDs * Corrected Typo in Barbarian Replacement IDs * Update players-handbook-2024.index Added source links for all files in PR * Update class-barbarian.xml Corrected Select name for Primal Knowledge * Update class-bard.xml Changing Expertise selects from Class Features to Proficiencies * Update class-rogue.xml Changes Expertise grants from Class Features to Proficiencies * Update class-bard.xml Fixed Jack of All Trades to work with both the old PHB14 and new PHB24 Skill Proficiencies * Update bard-valor.xml Removed <ul> for Combat Inspiration and replaced with standard formatting <p class="indent"> * Update barbarian-berserker.xml Change subclass header to <p class="flavor"> * Update barbarian-wild-heart.xml Change subclass header to <p class="flavor"> * Update barbarian-world-tree.xml Change subclass header to <p class="flavor"> * Update barbarian-zealot.xml Change subclass header to <p class="flavor"> * Update bard-dance.xml Change subclass header to <p class="flavor"> * Update bard-glamour.xml Change subclass header to <p class="flavor"> * Update bard-lore.xml Change subclass header to <p class="flavor"> * Update bard-valor.xml Change subclass header to <p class="flavor"> * Update druid-land.xml Change subclass header to <p class="flavor"> * Update druid-moon.xml Change subclass header to <p class="flavor"> * Update druid-sea.xml Change subclass header to <p class="flavor"> * Update druid-stars.xml Change subclass header to <p class="flavor"> * Update rogue-arcane-trickster.xml Change subclass header to <p class="flavor"> * Update rogue-assassin.xml Change subclass header to <p class="flavor"> * Update rogue-soulknife.xml Change subclass header to <p class="flavor"> * Update rogue-thief.xml Change subclass header to <p class="flavor"> * Update sorcerer-aberrant.xml Change subclass header to <p class="flavor"> * Update sorcerer-clockwork.xml Change subclass header to <p class="flavor"> * Update sorcerer-draconic.xml Change subclass header to <p class="flavor"> * Update sorcerer-wild.xml Change subclass header to <p class="flavor"> * Update warlock-archfey.xml Change subclass header to <p class="flavor"> * Update warlock-celestial.xml Change subclass header to <p class="flavor"> * Update warlock-fiend.xml Change subclass header to <p class="flavor"> * Update warlock-great-old-one.xml Change subclass header to <p class="flavor"> * Styling Updates for bard-dance.xml Styling Updates * Styling Update for druid-stars.xml * Source correction for rogue-assassin.xml * Styling Update for rogue-soulknife.xml * Typo Corrections for warlock-great-old-one.xml * Update class-barbarian.xml Class "short" setter description updated to match PHB24 wording * Update class-bard.xml Class "short" setter description updated to match PHB24 wording * Update class-druid.xml Class "short" setter description updated to match PHB24 wording * Update class-rogue.xml Class "short" setter description updated to match PHB24 wording * Update class-sorcerer.xml Class "short" setter description updated to match PHB24 wording * Update class-warlock.xml Class "short" setter description updated to match PHB24 wording * Update rogue-soulknife.xml Typo corrections in info description * Update druid-stars.xml Corrected spell ID grants * Update rogue-thief.xml Correction of info description * Update rogue-arcane-trickster.xml Correcting spell ID grants * Update druid-sea.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update druid-moon.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update druid-land.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update bard-glamour.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update barbarian-wild-heart.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update warlock-great-old-one.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update warlock-fiend.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update warlock-celestial.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update sorcerer-aberrant.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update sorcerer-clockwork.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update sorcerer-draconic.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update warlock-archfey.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update class-barbarian.xml Updated ASI rules to new standard - grant Feat, restrict Epic Boon options to level 19. * Update class-bard.xml Updated ASI rules to new standard - grant Feat, restrict Epic Boon options to level 19. * Update class-bard.xml Commented out PHB14 spell grants, inserted PHB24 spell grants * Update class-bard.xml Updated ASI grants to new naming convention * Update class-barbarian.xml Updated to new ASI naming conventions * Update class-druid.xml Updated ASI features to new naming conventions Commented out PHB14 spell grants, inserted PHB24 spell grants Updated languages to PHB24 * Update class-rogue.xml Updated ASI features to new naming conventions * Update class-sorcerer.xml Updated ASI features to new naming conventions * Update class-warlock.xml Updated ASI features to new naming conventions Commented out PHB14 spell grants, inserted PHB24 spell grants * Update eldritch-invocations.xml Commented out PHB14 spell grants, inserted PHB24 spell grants Updated Agonizing Blast, Eldritch Spear, and Repelling Blast invocations. * Update companions.xml Updated Source name to new standard "Player's Handbook 2024" * Update core/players-handbook-2024/classes/class-barbarian.xml Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> * Update class-barbarian.xml * Update class-bard.xml * Update class-druid.xml * Update class-rogue.xml * Update class-sorcerer.xml * Update class-warlock.xml * Update eldritch-invocations.xml Added Lessons of the First Ones repeatables * Update rogue-soulknife.xml * Update class-bard.xml * Update class-sorcerer.xml * Update companions.xml Added statblock information elements for DMG24 items * Update eldritch-invocations.xml * Update bard-lore.xml * Update sorcerer-clockwork.xml * Update class-druid.xml * Update class-barbarian.xml * Update class-bard.xml * Update class-rogue.xml * Update class-sorcerer.xml * Update class-warlock.xml * Update class-druid.xml Fix for Wild Shape CR display * Update druid-moon.xml Fixes for Wild Shape CR display * Apply suggestions from code review Applying Nick's suggestions from his review (3/10/25) Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update class-barbarian.xml Tidying up extra changes to the file based on Nick's review * Update class-barbarian.xml * Update class-bard.xml Updates to Bard class based on Nick's review * Update class-druid.xml Updated per Nick's Barbarian review * Update barbarian-berserker.xml * Update barbarian-wild-heart.xml * Update barbarian-world-tree.xml * Update barbarian-zealot.xml * Update class-rogue.xml Updated with respect to Nick's review * Update class-sorcerer.xml Updated per Nick's Review * Update class-warlock.xml Updated per Nick's Review * Update eldritch-invocations.xml Updated per Nick's review * Update bard-dance.xml * Update bard-glamour.xml * Update bard-lore.xml * Update bard-valor.xml * Update druid-land.xml * Update druid-moon.xml * Update druid-sea.xml * Update druid-stars.xml * Update rogue-arcane-trickster.xml * Update rogue-assassin.xml * Update rogue-soulknife.xml * Update rogue-thief.xml * Update sorcerer-aberrant.xml * Update sorcerer-clockwork.xml * Update sorcerer-draconic.xml * Update sorcerer-wild.xml * Update warlock-archfey.xml * Update warlock-celestial.xml * Update warlock-fiend.xml * Update warlock-great-old-one.xml * Update class-druid.xml * Update class-druid.xml * Update druid-moon.xml * Update barbarian-wild-heart.xml * Update bard-valor.xml * Update rogue-thief.xml * Update barbarian-wild-heart.xml Co-authored-by: @NickVendel * Update barbarian-wild-heart.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update eldritch-invocations.xml * Update eldritch-invocations.xml Updated to remove duplicate elements * Update eldritch-invocations.xml * Apply suggestions from code review Updates as per Nick's latest review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update class-druid.xml * Update class-rogue.xml * Update class-sorcerer.xml * Update class-druid.xml * Update class-druid.xml * Apply suggestions from code review Updates to Druid subs, Barb and Bard classes based on Nick's review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review First pass of druid updates from Nick's Review (can't do all in one go due to overlapping lines) Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Second batch of druid updates based on Nick's review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update barbarian-berserker.xml * Update barbarian-wild-heart.xml * Update barbarian-world-tree.xml * Update barbarian-zealot.xml * Update bard-dance.xml * Update bard-glamour.xml * Update bard-lore.xml * Update bard-valor.xml * Update rogue-arcane-trickster.xml * Update rogue-assassin.xml * Update rogue-soulknife.xml * Update rogue-thief.xml * Update sorcerer-aberrant.xml * Update sorcerer-clockwork.xml * Update sorcerer-draconic.xml * Update sorcerer-wild.xml * Update warlock-archfey.xml * Update warlock-celestial.xml * Update warlock-fiend.xml * Update warlock-great-old-one.xml * Update class-barbarian.xml * Update class-bard.xml * Update class-rogue.xml * Update class-sorcerer.xml * Update class-warlock.xml * Update bard-lore.xml * Update bard-lore.xml * Update class-rogue.xml * Apply suggestions from code review Updating Rogue, Sorcerer, and Warlock subclasses per Nick's review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Changes to Rogue, Sorcerer, and Warlock base classes per Nick's Review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update eldritch-invocations.xml * Apply suggestions from code review Updated Warlock Invocations per Nick's review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update rogue-soulknife.xml * Update rogue-soulknife.xml * Update druid-sea.xml * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update eldritch-invocations.xml * Update class-rogue.xml * Update class-bard.xml * Update class-druid.xml * Update class-sorcerer.xml * Update class-warlock.xml * Update rogue-arcane-trickster.xml --------- Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com>
* Add files via upload * Add files via upload * Update class-sorcerer.xml Removed "prepared spell slots" stats (erroneously copied from PHB2024 wizard file) * Adding Bard class file * Adding Bard subclass files * Adding rogue class * Adding Rogue subclasses * Adding Barbarian class file * Adding Barbarian subclass files * Added Druid and Warlock base classes * Adding Druid and Warlock subclasses * Adding Eldritch Invocations * Update eldritch-invocations.xml Correcting file location in the info block * Added Companions file * Update class-sorcerer.xml Added missing Replacement Feature elements for new PHB2024 features * Update class-bard.xml Added missing Replacement Feature elements for new PHB2024 features * Update druid-land.xml Removed Condition Immunity "Poisoned", as it is not part of the base app. * Update warlock-celestial.xml Corrected lvl 14 feature to be granted @ lvl 14 (was erroneously granted at lvl 10) * Update warlock-archfey.xml Corrected lvl 14 feature to be granted at lvl 14 (was erroneously granted at lvl 10) * Update class-rogue.xml 5d6 Sneak Attack option in class table was erroneously listed as "Sd6" * Uploading newest files to compare to current PR * Uploading new files to compare to current PR * Update class-bard.xml * Updated Replacement Tag names with _24_ marker * Updated Replacement Tag names with _24_ marker * Corrected Typo in Barb Replacement IDs * Corrected Typo in Barbarian Replacement IDs * Updated Monk file * Added subclasses for Fighter and Monk * Delete core/players-handbook-2024/companions.xml redundant with original PR * Delete core/players-handbook-2024/classes/class-barbarian.xml Redundant with original PR * Delete core/players-handbook-2024/classes/class-bard.xml Redundant with original PR * Delete core/players-handbook-2024/classes/class-druid.xml Redundant with original PR * Delete core/players-handbook-2024/classes/class-rogue.xml Redundant with original PR * Delete core/players-handbook-2024/classes/class-sorcerer.xml Redundant with original PR * Delete core/players-handbook-2024/classes/class-warlock.xml Redundant with original PR * Delete core/players-handbook-2024/classes/eldritch-invocations.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/barbarian-berserker.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/barbarian-wild-heart.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/barbarian-world-tree.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/barbarian-zealot.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/bard-dance.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/bard-glamour.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/bard-lore.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/druid-land.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/bard-valor.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/druid-moon.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/druid-sea.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/druid-stars.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/rogue-arcane-trickster.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/rogue-assassin.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/rogue-soulknife.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/rogue-thief.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/sorcerer-aberrant.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/sorcerer-clockwork.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/sorcerer-draconic.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/sorcerer-wild.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/warlock-archfey.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/warlock-celestial.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/warlock-fiend.xml Redundant with original PR * Delete core/players-handbook-2024/archetypes/warlock-great-old-one.xml Redundant with original PR * Update players-handbook-2024.index Added source links for all files in PR * Rename monk-shadows.xml to monk-shadow.xml corrected xml file name * Update monk-mercy.xml Removed spellcasting from Mercy subclasss * Update fighter-psi-warrior.xml Fixed incorrect ID * Update fighter-psi-warrior.xml Removed Psi Warrior spellcasting * Update monk-elements.xml Removed Warrior of the Elements spellcasting * Update monk-shadow.xml Removed Warrior of Shadow spellcasting * Update fighter-battle-master.xml Change subclass header to <p class="flavor"> * Update fighter-champion.xml Change subclass header to <p class="flavor"> * Update fighter-eldritch-knight.xml Change subclass header to <p class="flavor"> * Update fighter-psi-warrior.xml Change subclass header to <p class="flavor"> * Update monk-elements.xml Change subclass header to <p class="flavor"> * Update monk-mercy.xml Change subclass header to <p class="flavor"> * Update monk-open-hand.xml Change subclass header to <p class="flavor"> * Update monk-shadow.xml Change subclass header to <p class="flavor"> * Small styling updates for monk-mercy.xml * Styling Update for monk-shadow.xml * Styling Update for monk-open-hand.xml * Styling Update for monk-elements.xml * Styling Update for class-monk.xml * Styling Update for fighter-psi-warrior.xml * Update class-monk.xml Class "short" setter description updated to match PHB24 wording * Update fighter-battle-master.xml Updated Combat Superiority wording and removed the DC from every maneuver (since it is shown as part of the main feature right above) * Update class-monk.xml Updated ASI features to new naming conventions * Update class-monk.xml * Update class-monk.xml * Update class-monk.xml * Update class-monk.xml * Update fighter-battle-master.xml * Update class-monk.xml Updated per Nick's review * Update fighter-battle-master.xml * Update fighter-champion.xml * Update fighter-eldritch-knight.xml * Update fighter-psi-warrior.xml * Update monk-elements.xml * Update monk-mercy.xml * Update monk-open-hand.xml * Update monk-shadow.xml * Update monk-open-hand.xml * Update class-monk.xml * Update fighter-battle-master.xml * Update fighter-champion.xml * Update fighter-eldritch-knight.xml * Update fighter-psi-warrior.xml * Update monk-elements.xml * Update monk-mercy.xml * Update monk-open-hand.xml * Update monk-shadow.xml * Update class-monk.xml * Apply suggestions from code review Committing Nick's Battlemaster suggestions Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Committing Nick's suggestions for Champion, EK, and Psi Warrior Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Committing Nick's suggestions for monk subclasses Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Committing Nick's suggestions for monk class Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update fighter-battle-master.xml * Update fighter-eldritch-knight.xml * Update fighter-eldritch-knight.xml Updated with Nick's latest file * Update class-monk.xml Updated with Nick's latest file * Apply suggestions from code review Monk file updates per Nick's review (1/30) Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> --------- Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: aurorabuilderlegacy <73967377+aurorabuilderlegacy@users.noreply.github.com>
* [PHB24] Spells * Update spells.xml * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update spells.xml Tregolani: changed durations, and added keywords * Update spells.xml * Update core/players-handbook-2024/spells.xml Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update core/players-handbook-2024/spells.xml Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * The baseline Meriadar's PHB24 Spells branch at the time of commit 2fc8e5f Co-Authored-By: MeriadarGoblin <99753019+MeriadarGoblin@users.noreply.github.com> Co-Authored-By: tregolani <64651202+tregolani@users.noreply.github.com> * My changes * Additional changes --------- Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: aurorabuilderlegacy <73967377+aurorabuilderlegacy@users.noreply.github.com>
* Zencha's baseline (#2) Changes from the Zencha's PR --------- Co-authored-by: Zencha70 <101748747+Zencha70@users.noreply.github.com> Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Changes from reviews • Primarily focused on my review of the classes, including somewhat forgotten (by me) Monk class along with Eldritch Knight subclass of Fighter. • Including some of the changes from Tregolani's and formerlyknownasmilky's reviews. Co-Authored-By: tregolani <64651202+tregolani@users.noreply.github.com> Co-Authored-By: formerlyknownasmilky <210542841+formerlyknownasmilky@users.noreply.github.com> * Removal of Monk and Eldritch Knight files in favor of tregolani's #290 PR. --------- Co-authored-by: Zencha70 <101748747+Zencha70@users.noreply.github.com> Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> Co-authored-by: formerlyknownasmilky <210542841+formerlyknownasmilky@users.noreply.github.com> Co-authored-by: aurorabuilderlegacy <73967377+aurorabuilderlegacy@users.noreply.github.com>
* Part 1 * Part 2 * Removed spellcasting ability select from Fiendish Legacy * Moved diles to their proper folders * Forgot to put these in the right spot * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Made changes suggested in comments * Update Kaladesh Elf version number Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Update Vampire version number * Replace "Grants" with "Racial Trait" for Creature Types * Ravnica Goblin version number Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> --------- Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com>
* Lots of minor fixes • indentation fixes • added Background Equipment Packs • minor fixes to the Backgrounds • minor fixes to Classes (including fixes for Traits sidebar, rules for mutliclassing, use of book-accurate `Spell Slots per Spell Level` instead of `Spell Slots per Level` and `Subclass feature` instead of `Subclass Feature`) • added missing `[Class] CLASS FEATURES` headings before divs • blocked ability to Multiclass from/into different versions of the same Class (such as from PHB Fighter into PHB24 Fighter) • removed `supports="Boon"` from ASI features • added and implemented Feat Unlocker • added keywords for Artisan's Tools, so it's easier to search for them in "Tools" Equipment category • updated naming convention of Expertise elements • removed any `innate speed`s that were in PHB24 • and added missing descriptions to the old PHB Class files. * Changing the source name * Additional changes • downgraded update versions of the files, so there won't be unnecessary version jump. • added image for the book. • added description to and fixed the Source. • updated Source for the original PHB, in order to make it toggleable. Also changed the release date, so it is placed alongside other Core Books in the Sources menu, * Shortening terms for sheet descriptions • `Hit Points` shortened to `HPs` or `HP`. • `Temporary Hit Points` shortened to `THPs`. • `Hit Point Dice` shortened to `Hit Dice`. • `Armor Class` shortened to `AC`. • also fixed Lifedrinker to maintain the "minimum of 1" logic. * Blocked ability to select different versions of the same feature • moved tags in some of the elements to be in a following order: supports > requirements > prerequisite > compendium. • added Feat Unlocker for original PHB, which in combination with PHB24 Unlocker allows to take mutliple versions of the same ability. • fixed the PHB24 Source file. * Moving elements from internal PHB to Internal and ALE files Major changes to how PHB and PHB24 operate: • creation of the `Aurora Legacy Essentials` (abbreviated to ALE) source. • multiple elements that were previous set to PHB source are now changed to either Internal (for elements that only have mechanical use) or ALE (for elements that can be used for reference as well) sources, in order to allow PHB source to be completely disabled without breaking the functionality of the app. • all of the references to PHB24 Proficiencies were either deleted, or changed to ex-PHB elements. So both PHB and PHB24 use the same elements, which reduces amount of duplicates users will see or get within the app. • blocked the ability to multiclass into the different versions of the same Class. • some PHB24 republished content have unique (or just different) properties in comparison to the original PHB, so we had to create duplicate elements and block the ability to have both elements (one such example being Draconic language, which is now Standard) Other changes: • removed unnecessary `<compendium display="false" />` lines from Internal elements, as those elements are hidden from Compendium by default. • fixed the PHB24.index file. Now everything is in place. • deleted now empty Expertise file from PHB24. • created Multiclass Unlocker that allows to bypass the multiclass prerequisites for all of the PHB and PHB24 classes (we'll probably expand the usage further later). • for PHB24, changed supports in Expertise features and elements to avoid any possible conflict with potential Tool Expertises, while still allowing for generic Expertise support, in case there's a type-agnostic feature in the future. • updated classes that had a change in their Skill lists, which now rely on a new PHB24-based support. • added Improvised Weapons proficiency for Tavern Brawler (also updated PHB24-version of the feat's sheet description). • added a Rules file to PHB24, meant for Glossary entries. • updated original PHB's Rogue file. 1) minor formating fixes. 2) fixed Sneak Attack and Thieves' Cant elements. 3) changed Expertise elements so they granted new Expertise proficiencies elements instead of stats (doesn't create breaking change), which creates better interactions between old and new Feats and other features that involve Expertise. • all Crossbows now use PHB24-style names which avoids issues with type-specific Magic Weapons. • added Polearm weapon group, and relevant supports. • added supports into relevant Weapon Proficiencies, such as PHB24-specific support for Heavy property of the Lance. • moved Languages from PHB to ALE (file will need to be obsoleted in the future update). * Changes to Companion files • removed all Companion type elements that don't have a use within the PHB24 elements. • changed the order of setters in order to align them closer to how they appear in the statblocks. • changed IDs to MM25 in order to make transition to that source smoother once it is ready. • Applied any relevant Errata changes. • Applied MM25 formatting to all statblocks within PHB24 source. • fixed Saving Throws for Cat and Goat. * preventing breaking change * fix for the wrong IDs * Review & misc. changes • changed back to innate speeds • fixed Jack of All Trades feature • fixed wrong Language IDs • Blessed Warrior and Druidic Warrior Feats are now restricted to Paladin and Ranger respectively. • fixed wrong Weapon Proficiency IDs • changed source to PHB24 for elements in the proficiencies file. • removed speed stat from Charger (copy-paste mistake) * Additional changes • fixes based on reviews • added Spellcasting Grants to old spellcasters, which would allow user utilizing PHB Classes to gain PHB24 Feats to require those Grants. * Fix for PHB Fighter file version
* Fixed expertise IDs for Scholar feature * Pact of the Chain and Find Familiar fixes Added requirements to ensure no duplicate familiar selection from 2024 Pact of the Chain * Added familiar select to 2014 Find Familiar * Apply suggestions that GitHub disregarded * Fix Keen Senses selection * Added Blessed Warrior prerequisite text and changed 2014 Barbarian and 2024 Monk capstone ASIs * Forgot to fix language supports * 2024 Barbarian capstone changes and added Keen Senses description to Elf * Fixed Greatclub ID * Change Blessed Warrior prerequisite Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * [PHB24] Fixes from Testing (#4) * Misc. Fixes • moved elements from Internal source/file to ALE, in order for them to still appear under Additional Proficiency category of equipment. • removed requirements from Boon's ASI elements. • fixed incorred Proficiency in the Guide Background • fixed many instances of incorrect description formatting. • blocked multiclass version of the Fighter from gaining Class's Skill Proficiencies. • removed unnecessary parentheses from requirements of Cunning Strike selects. • changed Boon and non-Origin Feat requirements to character level instead of Class level, allowing for mutliclass characters to pick up them once character reaches relevant level. • added missing stats to Irresistible Offense sub-elements. • fixed copy-paste typo in Observant Feat. • added a note to the PHB24 source, that recognizes it as a `D&D 5.5e` source. • fixed wrong Proficiency grant in the PHB Rogue class. • Draconic language and new Polearm proficiency is placed back under PHB source, to hide it when the source is disabled in favor of PHB24 version of relevant elements. * Blocked duplicates • blocked ability for Warlock to take mutliple versions of the same Eldritch Invocation • blocked ability for Sorcerer to take multiple versions of the same Metamagic • also some minor fixes, including: removal of appends in the Eldritch Invocation file, moving those relevant selects to the Class instead; changed formatting to PHB's Eldritch Invocations file; removed pointless Feature Replacement Grants from Metamagic options. * More Fixes and Compatibility Changes • added Optional Background Feature to PHB24 source, which allows to take Origin Feat by Backgrounds pre-PHB24 Backgrounds as suggested by PHB24 rules. • changed supports for PHB24 Battle Master's Maneuvers to avoid duplicates and any potential mechanical issues in the future. • added references to all of the PHB24 Backgrounds so that it's easier to choose Background based on a given Feat. • added proper prerequisites to PHB24 Druidic Warrior Feat. • added PHB24 Pacts to the requirements of pre-PHB24 invocations, so that you can still take previous versions of the Invocations even if you use new Pacts. * correcting sources * Compatibility Fixes for Subclasses • also swapped `&&` to `,` in both Elf Races, not a breaking change. • there's a breaking change in both Bard's and Warlock's Mage of Strixhaven Subclasses, due to a fix to a copy-paste typo. * fix copy-paste error * Updated versions Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> * Replaced "grant name=" with "grant id=" * Apply suggestions from code review Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com> * Ability Score Maximum Fixes (#5) * Misc. Fixes • moved elements from Internal source/file to ALE, in order for them to still appear under Additional Proficiency category of equipment. • removed requirements from Boon's ASI elements. • fixed incorred Proficiency in the Guide Background • fixed many instances of incorrect description formatting. • blocked multiclass version of the Fighter from gaining Class's Skill Proficiencies. • removed unnecessary parentheses from requirements of Cunning Strike selects. • changed Boon and non-Origin Feat requirements to character level instead of Class level, allowing for mutliclass characters to pick up them once character reaches relevant level. • added missing stats to Irresistible Offense sub-elements. • fixed copy-paste typo in Observant Feat. • added a note to the PHB24 source, that recognizes it as a `D&D 5.5e` source. • fixed wrong Proficiency grant in the PHB Rogue class. • Draconic language and new Polearm proficiency is placed back under PHB source, to hide it when the source is disabled in favor of PHB24 version of relevant elements. * Blocked duplicates • blocked ability for Warlock to take mutliple versions of the same Eldritch Invocation • blocked ability for Sorcerer to take multiple versions of the same Metamagic • also some minor fixes, including: removal of appends in the Eldritch Invocation file, moving those relevant selects to the Class instead; changed formatting to PHB's Eldritch Invocations file; removed pointless Feature Replacement Grants from Metamagic options. * More Fixes and Compatibility Changes • added Optional Background Feature to PHB24 source, which allows to take Origin Feat by Backgrounds pre-PHB24 Backgrounds as suggested by PHB24 rules. • changed supports for PHB24 Battle Master's Maneuvers to avoid duplicates and any potential mechanical issues in the future. • added references to all of the PHB24 Backgrounds so that it's easier to choose Background based on a given Feat. • added proper prerequisites to PHB24 Druidic Warrior Feat. • added PHB24 Pacts to the requirements of pre-PHB24 invocations, so that you can still take previous versions of the Invocations even if you use new Pacts. * correcting sources * Compatibility Fixes for Subclasses • also swapped `&&` to `,` in both Elf Races, not a breaking change. • there's a breaking change in both Bard's and Warlock's Mage of Strixhaven Subclasses, due to a fix to a copy-paste typo. * fix copy-paste error * Fixes for Ability Score Maximum rules Change to make sure Ability Score Maximum setting works as intended while still blocking stacking for most elements that increase ability score's maximum. --------- Co-authored-by: NickVendel <46818179+NickVendel@users.noreply.github.com> Co-authored-by: Tel0k <94142741+Tel0k@users.noreply.github.com> Co-authored-by: tregolani <64651202+tregolani@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.