Adv-HW-2 done (with couple bugs)#52
Open
psc478 wants to merge 3 commits intoAustinCodingAcademy:masterfrom
Open
Adv-HW-2 done (with couple bugs)#52psc478 wants to merge 3 commits intoAustinCodingAcademy:masterfrom
psc478 wants to merge 3 commits intoAustinCodingAcademy:masterfrom
Conversation
added 3 commits
February 5, 2018 12:40
…disappear on navbar click, and for the styling on the ProductDetails to look normal rather than squashed.
jw56578
reviewed
Feb 6, 2018
| } | ||
| } | ||
|
|
||
| console.log("Products filtered:",allProducts.filter(filterByCat)); |
Contributor
There was a problem hiding this comment.
good job console logging to see what is going on
jw56578
reviewed
Feb 6, 2018
|
|
||
| <li><a href="#" onClick={()=>{ | ||
| props.changeCategory("tires"); | ||
| noHash; |
Contributor
There was a problem hiding this comment.
lines 20 -21 are inside an arrow function where you need to type only valid code
typing the name of a function noHash doesn't accomplish anything
executing the function would accomplish something
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.