feature-5: Various improvements, updates and fixes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All methods in this class are functional by nature.
Make fail-early, improve compatibility, representative handler names.
The Knowledge Book item is being consumed when used. Replaced with a feather. Added glint for good measure.
Caused console spam when player drags inventory item with GUI open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I really like the idea and straight forward execution of your plugin and hope to contribute.
Fully tested against version 1.21.1.
Overview
5f3e950 changes the default item to a feather because I found that the knowledge book was consumed without providing feedback when used while not targeting a block in reach. I'm unsure if this behavior was intentional or not.
Have a nice day :)