Skip to content

Preserve linked CSS layout wrapper styles #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Jun 24, 2026
Merged

Preserve linked CSS layout wrapper styles #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion php-transformer/src/HtmlToBlocks/HtmlTransformer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,7 +1062,7 @@ private function isHighValueStyledElement(DOMElement $element): bool
$this->attr($element, 'role'),
))));

if ( preg_match('/(?:^|[^a-z0-9])(?:btn|button|cta|action|nav|menu|card|tile|panel|pricing|price|product)(?:[^a-z0-9]|$)/', $tokens) ) {
if ( preg_match('/(?:^|[^a-z0-9])(?:btn|button|cta|action|nav|menu|card|tile|panel|pricing|price|product|grid|columns|layout|stack|cluster|row|wrap)(?:[^a-z0-9]|$)/', $tokens) ) {
return true;
}

Expand Down Expand Up @@ -1133,10 +1133,17 @@ private function safeVisualDeclarations(array $declarations): array
'border-width',
'box-shadow',
'color',
'align-items',
'column-gap',
'display',
'flex-direction',
'flex-wrap',
'font-size',
'font-weight',
'gap',
'grid-template-columns',
'grid-template-rows',
'justify-content',
'line-height',
'margin',
'margin-bottom',
Expand All @@ -1148,6 +1155,7 @@ private function safeVisualDeclarations(array $declarations): array
'padding-left',
'padding-right',
'padding-top',
'row-gap',
'text-align',
'text-decoration',
'text-transform',
Expand Down
39 changes: 39 additions & 0 deletions php-transformer/tests/fixtures/parity/artifact-linked-css-layout-wrapper-style-signals.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
{
"schema": "blocks-engine/php-transformer/parity-fixture/v1",
"name": "artifact-linked-css-layout-wrapper-style-signals",
"description": "Applies safe visual declarations from linked class CSS to generic grid and flex layout wrappers.",
"source_reference": {
"repo": "php-transformer",
"path": "tests/fixtures/parity/artifact-linked-css-layout-wrapper-style-signals.json",
"notes": "Covers layout wrapper class CSS used by generated static HTML fixtures, such as grid columns and flexible card rows."
},
"legacy_comparison": {
"skip": true,
"reason": "This upstream CSS layout signal fixture has no downstream legacy comparison."
},
"operation": "artifact_compiler.compile",
"input": {
"artifact": {
"files": [
{
"path": "index.html",
"kind": "html",
"content": "<!doctype html><html><head><title>Layout wrappers</title><link rel=\"stylesheet\" href=\"assets/site.css\"></head><body><main><section class=\"hero-grid\"><div><h1>Plan the work</h1><p>Keep the lead and aside aligned.</p></div><aside><p>Side note</p></aside></section><section class=\"shift-card\"><span>1</span><div><h2>First shift</h2><p>Flexible card row.</p></div></section></main></body></html>"
},
{
"path": "assets/site.css",
"kind": "css",
"content": ".hero-grid{display:grid;grid-template-columns:1fr 420px;gap:clamp(24px,4vw,64px);align-items:center}.shift-card{display:grid;grid-template-columns:auto 1fr;gap:16px;align-items:start}"
}
]
}
},
"expect": [
{ "path": "status", "assert": "equals", "value": "success" },
{ "path": "serialized_blocks", "assert": "contains", "value": "hero-grid" },
{ "path": "serialized_blocks", "assert": "contains", "value": "display:grid;grid-template-columns:1fr 420px;gap:clamp(24px,4vw,64px);align-items:center" },
{ "path": "serialized_blocks", "assert": "contains", "value": "shift-card" },
{ "path": "serialized_blocks", "assert": "contains", "value": "display:grid;grid-template-columns:auto 1fr;gap:16px;align-items:start" },
{ "path": "fallbacks", "assert": "count", "count": 0 }
]
}
Loading