feat: GOP party → GOP / Grand Old Party#3232
Open
hippietrail wants to merge 3 commits into
Open
Conversation
Since this involved computationally creating the right-side of a string test that requires the right side to be all-lowerse, I've also included debug-time-only asserts to ensure right sides of such tests are always all-lowercase, and a pair of unit tests to make sure that they work as intended.
|
|
||
| fn eq_str(&self, other: &str) -> bool { | ||
| // Assert that the right-hand side is all-lowercase as required | ||
| debug_assert!( |
Collaborator
There was a problem hiding this comment.
I'm a little confused here. The name of the function (and the way I would use it) does not imply that the right side is lowercase. Why is that necessary?
Collaborator
Author
There was a problem hiding this comment.
It's always been documented. It was an optimization because in practice the right side was always a literal:
harper-core/src/char_string.rs
Should I add a to-lowercase into the loop on the right-hand side and remove this requirement?
|
|
||
| fn eq_ch(&self, other: &[char]) -> bool { | ||
| // Assert that the right-hand side is all-lowercase as required | ||
| debug_assert!( |
Collaborator
There was a problem hiding this comment.
Same as my other comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I noticed "GOP party" in a YouTube comment and thought "we have a linter that can fix that"!
It turned out to be a little complicated by the fact that it's the first one that's a proper noun so when fully-spelled-out each word should begin with a capital.
Since this involved computationally creating the right-side of a string test that requires the right side to be all-lowercase, I've also included debug-time-only asserts to ensure right sides of such tests are always all-lowercase. And a pair of unit tests to make sure that they work as intended.
How Has This Been Tested?
A unit test for the redundancy and two unit tests for the lowercase-right-side invariant.
Thence
just test-rustChecklist