feat: add convenience methods to Token for direct equality checks#3266
Open
hippietrail wants to merge 4 commits into
Open
feat: add convenience methods to Token for direct equality checks#3266hippietrail wants to merge 4 commits into
Token for direct equality checks#3266hippietrail wants to merge 4 commits into
Conversation
- Add `eq_ch()` and `eq_str()` methods to `Token` to eliminate intermediate `get_ch()`/`get_str()` calls throughout the codebase. - Update all usage sites and remove unused CharStringExt imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I noticed it's a very common pattern to get the content of a token and then check if it's the same as a string or char array literal. In fact there are multiple functions to get the token content, as a string or as a char array reference. It's almost always better to use the latter since it can do comparisons against other string types using only iterators and avoiding allocations and full type conversions.
In some places the change only saves a couple of characters, but in other places it saves one or two lines. I think it makes the code more expressive and easier to read and makes accidentally introducing unnecessary type conversions and allocations a little harder for new contributors copying existing code.
eq_ch()andeq_str()methods toTokento eliminate intermediateget_ch()/get_str()calls throughout the codebase.CharStringExtimports.How Has This Been Tested?
cargo testChecklist