fix: resolve #3361 — Incorrect grammar analysis on apostrophe possessive name#3432
Open
chinhkrb113 wants to merge 1 commit into
Conversation
…he possessive name Fixes Automattic#3361 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
hippietrail
added
rust
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Combined multi-file contribution:
Changes
harper-core/src/linting/repeated_words.rsWhy
harper-core/src/linting/repeated_words.rs: The "repeated be verb redundancy" or "repeated words" lint is incorrectly flaggingKamen'sas a repeated word when it appears aftershe'sin the same sentence. The issue is that the lint is treating the'sinKamen's(possessive) as equivalent to the'sinshe's(contraction of "is"), and flagging it as a repeated word/verb. The lint needs to distinguish between possessive'sand contracted's(is/has), or at minimum not flag words that include a possessive'sattached to a proper noun/unknown word as repeated instances of a prior contraction.