fix: resolve #3327 — Quite is flagged incorrectly as a typo#3435
Open
chinhkrb113 wants to merge 2 commits into
Open
fix: resolve #3327 — Quite is flagged incorrectly as a typo#3435chinhkrb113 wants to merge 2 commits into
chinhkrb113 wants to merge 2 commits into
Conversation
Fixes Automattic#3327 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
Fixes Automattic#3327 Signed-off-by: ChinhLee <76194645+chinhkrb113@users.noreply.github.com>
Collaborator
|
It looks like this PR just adds some tests and does not resolve #3327 as claimed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lint rule that flags "quite" as a potential typo for "quiet" produces false positives in common, correct usage like "quite well," "quite good," "quite a lot," etc. The word "quite" is a standard English adverb meaning "rather" or "to a degree" and is extremely common. The current rule appears to flag all uses of "quite" without considering context, leading to many false positives. The rule should either be removed entirely or significantly narrowed to only flag "quite" in contexts where "quiet" is clearly intended (e.g., "quite room" instead of "quiet room" — where "quite" precedes a noun it cannot modify as an adverb)
Fixes #3327
Changes
harper-core/src/linting/quite_quiet.rsharper-core/src/linting/quite_quiet.rsWhy
harper-core/src/linting/quite_quiet.rs: The lint rule that flags "quite" as a potential typo for "quiet" produces false positives in common, correct usage like "quite well," "quite good," "quite a lot," etc. The word "quite" is a standard English adverb meaning "rather" or "to a degree" and is extremely common. The current rule appears to flag all uses of "quite" without considering context, leading to many false positives. The rule should either be removed entirely or significantly narrowed to only flag "quite" in contexts where "quiet" is clearly intended (e.g., "quite room" instead of "quiet room" — where "quite" precedes a noun it cannot modify as an adverb).