Avoid mass noun lints for ing modifiers#3457
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1994
Description
This updates the mass noun countability rule to avoid treating
-ingwords as countability errors when they are acting as present-participle modifiers before a noun head.It covers adjective chains such as
a working direct linkand slash-separated modifier chains such asa prototyping/testing/learning tool, while preserving existing mass-noun corrections likeone clothing based on weather conditions.Demo
N/A; linter behavior is covered by unit tests.
How Has This Been Tested?
CARGO_HOME=$PWD/.cargo-home CARGO_TARGET_DIR=$PWD/target cargo test -p harper-core linting::mass_nouns::noun_countability::tests:: -- --nocaptureCARGO_HOME=$PWD/.cargo-home CARGO_TARGET_DIR=$PWD/target cargo fmt --checkCARGO_HOME=$PWD/.cargo-home CARGO_TARGET_DIR=$PWD/target cargo test -p harper-coregit diff --checkAI Disclosure
OpenAI GPT-5 assisted with the implementation and validation.
If Your PR Implements or Enhances a Linter
Checklist