fix: correct false flags for yourself, out right, and fanfiction#3529
Closed
Chessing234 wants to merge 2 commits into
Closed
fix: correct false flags for yourself, out right, and fanfiction#3529Chessing234 wants to merge 2 commits into
Chessing234 wants to merge 2 commits into
Conversation
hippietrail
suggested changes
May 28, 2026
Collaborator
hippietrail
left a comment
hippietrail
left a comment
There was a problem hiding this comment.
Please use our PR template, paying attention to the AI/bot fields.
For AI PRs I'd prefer separate PRs for each issue, even when the user has filed them as a combined GitHub issue. But I especially don't like addressing the unrelated #3490 in with the ones for #3525 - especially without being mentioned in the PR description.
That's just my opinion though, would be better to hear @elijah-potter 's opinion.
| fandango/~NgSV | ||
| fandom/~N | ||
| fanfare/~NwSgV | ||
| fanfiction/S |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug: PossessiveYour flagged 'you yourself', DisjointPrefixes flagged 'out right' before 'away', and fanfiction was missing from dictionary.
root cause: 'yourself' wasn't in homograph exception list for PossessiveYour, 'right' wasn't in out exceptions for DisjointPrefixes, and fanfiction wasn't in the curated dictionary.
why fix is correct: added exceptions and dictionary word to prevent these false flags.