CRM: Fix autoformat goofs plus additional tweaks#47624
Merged
Conversation
github-actions
Bot
added
[CRM] MailPoet Module
[CRM] WooSync Module
[Plugin] CRM
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
github-actions
Bot
added
[Status] Needs Author Reply
3 tasks
Code Coverage SummaryCoverage changed in 4 files.
|
github-actions
Bot
removed
the
[Status] Needs Author Reply
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes some issues introduced by code cleanup in #46809.
Proposed changes
This primarily removes extra whitespace within attributes. In many cases, I removed various redundant conditions and/or multilined the attributes, which improved readability. I skipped
classattributes, as whitespace has no effect.To keep myself engaged during the review I also cleaned up a handful of PHPCS notices, adding translation messages and removing redefined globals and unused vars.
Other information
Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions
Review the code.