Replace Spinner from jetpack-components with wp-components Spinner#48163
Replace Spinner from jetpack-components with wp-components Spinner#48163
Conversation
| Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete. |
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Protect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Automattic For agencies client plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
8abe6cc to
974e06e
Compare
…inner. Remove the custom Spinner component from `@automattic/jetpack-components` and replace all usages with `Spinner` from `@wordpress/components`.
0758401 to
6420847
Compare
|
Maybe close this one since #47451 already took care of most of the consumer-side work. Having the deprecation notice in place we can hold on the deletion. I can setup a schedule for Sep-Oct to finally delete the component and with #48487 also in the works this should happen organically. WDYT? Otherwise, let's just pick the commits that delete the component (rebase or new PR) and move forward. |
|
Sure 👍 |
Part of #48160
Remove the custom Spinner component from
@automattic/jetpack-componentsand replace all usages withSpinnerfrom@wordpress/components.There's no Spinner in
wp-uiyet so using the older one.Proposed changes
Licensing screen (My Jetpack -> activate license)
Before
After

Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions