Skip to content

Replace Spinner from jetpack-components with wp-components Spinner#48163

Closed
simison wants to merge 3 commits intotrunkfrom
update/rna-components-spinner
Closed

Replace Spinner from jetpack-components with wp-components Spinner#48163
simison wants to merge 3 commits intotrunkfrom
update/rna-components-spinner

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Apr 18, 2026

Part of #48160

Remove the custom Spinner component from @automattic/jetpack-components and replace all usages with Spinner from @wordpress/components.

There's no Spinner in wp-ui yet so using the older one.

Proposed changes

Licensing screen (My Jetpack -> activate license)

Before

After
Screenshot 2026-04-19 at 11 21 27

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Go to '..'

@github-actions
Copy link
Copy Markdown
Contributor

Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 18, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Boost plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Automattic For agencies client plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 18, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented Apr 18, 2026

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

@simison simison force-pushed the update/rna-components-spinner branch from 8abe6cc to 974e06e Compare April 19, 2026 14:37
simison added 3 commits April 19, 2026 11:31
…inner.

Remove the custom Spinner component from `@automattic/jetpack-components` and
replace all usages with `Spinner` from `@wordpress/components`.
@simison simison force-pushed the update/rna-components-spinner branch from 0758401 to 6420847 Compare April 19, 2026 15:32
@github-actions github-actions Bot added the [Plugin] Boost A feature to speed up the site and improve performance. label Apr 19, 2026
@simison simison marked this pull request as ready for review April 19, 2026 15:49
@CGastrell
Copy link
Copy Markdown
Contributor

Maybe close this one since #47451 already took care of most of the consumer-side work. Having the deprecation notice in place we can hold on the deletion. I can setup a schedule for Sep-Oct to finally delete the component and with #48487 also in the works this should happen organically. WDYT? Otherwise, let's just pick the commits that delete the component (rebase or new PR) and move forward.

@simison
Copy link
Copy Markdown
Member Author

simison commented May 5, 2026

Sure 👍

@simison simison closed this May 5, 2026
@simison simison deleted the update/rna-components-spinner branch May 5, 2026 08:00
@github-actions github-actions Bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants