Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 🔴 Action required: We would recommend that you add a section to the PR description to specify whether this PR includes any changes to data or privacy, like so: Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Search plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCannot generate coverage summary while tests are failing. 🤐 Please fix the tests, or re-run the Code coverage job if it was something being flaky. |
e66a948 to
d8c5fc5
Compare
Summary
autocomplete.mov
Adds an option to use auto-complete instead of search-as-you-type. So instead of getting search results as you type, you get suggestions for search queries as you type.
Hits a new REST API endpoint, and a new Elasticsearch index.
Testing instructions
Apply this 214458-ghe-Automattic/wpcom on your sandbox.
Sandbox the public API
Must use a Jurassic Tube or Jurassic Ninja (or other site with an active Jetpack connection and a Jetpack Search subscription).

Enable the option in jetpack search settings to enable search suggestions
Try typing a search query. You should see some suggestions for search queries. If you click on one, it will execute the search.
If you want to test on the fieldguide, do the following
Sandbox these sites:
fieldguide.automattic.com
automattictraining.wordpress.com
Run this on your sandbox to get this branch for jetpack
Do not checkout trunk, but rather stay on the jetpack-search-auto-complete branch.
You must visit the fieldguide while logged in, but you must also avoid HSTS / SSL errors. Search the field guide for "ssl chrome" to see suggestions on how to avoid SSL issues.